Skip to content

kernel/riscv64:Added support for omatcopy on RISCV64_ZVL256B#5265

Merged
martin-frbg merged 3 commits intoOpenMathLib:developfrom
guoyuanplct:develop
May 17, 2025
Merged

kernel/riscv64:Added support for omatcopy on RISCV64_ZVL256B#5265
martin-frbg merged 3 commits intoOpenMathLib:developfrom
guoyuanplct:develop

Conversation

@guoyuanplct
Copy link
Copy Markdown
Contributor

I modified the omatcopy implementation for riscv64_zvl256b, achieving a certain performance improvement.
image

@guoyuanplct
Copy link
Copy Markdown
Contributor Author

It might be worth considering moving this test — which appears to occasionally hang — to the end, or perhaps adding a timeout (e.g., 3 minutes) to allow for a safe restart if necessary.
image

@guoyuanplct
Copy link
Copy Markdown
Contributor Author

guoyuanplct commented May 16, 2025

I tried a function that restarts the deadlock test after it gets hanged. This function restarts the program if it runs beyond a certain time limit, with a maximum of 10 retries. In my forked branch, I did some basic testing. On average, the number of retries was around 5 to 8 times. Or we can continue to increase the number of restarts, since each run is very short and won't have a significant impact on the overall time.

@martin-frbg
Copy link
Copy Markdown
Collaborator

Okay, thanks, let's go with your version then - certainly more elegant than my quick fix of letting the entire job time out faster. Eventually this can hopefully be fixed by a newer qemu, or changes to the virtual hardware environment of the job.
(The hanging utest is most likely the fork-and-run-dgemm one, which I haven't seen hang on actual hardware)

@martin-frbg martin-frbg added this to the 0.3.30 milestone May 17, 2025
@martin-frbg martin-frbg merged commit 0b0bb99 into OpenMathLib:develop May 17, 2025
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants