Fix bug where openblas_set_threads_callback_function does not support modyfing symbol prefix and suffix in shared library#5594
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Jan 6, 2026
Conversation
… modyfing symbol prefix and suffix in shared library
Collaborator
|
thank you |
Contributor
|
Should these symbols be limited to multithreaded builds? I'm seeing this error while trying to build a single-threaded build on macOS: It looks like this is because blas_server_callback.c (which defines OpenBLAS/driver/others/Makefile Lines 8 to 13 in 45e9820 |
al3xtjames
added a commit
to al3xtjames/OpenBLAS
that referenced
this pull request
Jan 18, 2026
gensymbol was updated in OpenMathLib#5594 to support the openblas_set_threads_callback_function symbol. This caused SMP-disabled builds to regress as openblas_set_threads_callback_function is only defined when SMP is enabled. Update gensymbol to only define openblas_set_threads_callback_function when SMP is enabled in the build.
al3xtjames
added a commit
to al3xtjames/OpenBLAS
that referenced
this pull request
Jan 18, 2026
gensymbol was updated in OpenMathLib#5594 to support the openblas_set_threads_callback_function symbol. This caused SMP-disabled builds to regress as openblas_set_threads_callback_function is only defined when SMP is enabled. Fix this by updating gensymbol to conditionally add the symbol when SMP is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.