docs: fix iOS build script & use xcrun SDK path#5596
Merged
martin-frbg merged 2 commits intoOpenMathLib:developfrom Jan 10, 2026
Merged
docs: fix iOS build script & use xcrun SDK path#5596martin-frbg merged 2 commits intoOpenMathLib:developfrom
martin-frbg merged 2 commits intoOpenMathLib:developfrom
Conversation
martin-frbg
reviewed
Jan 10, 2026
| CFLAGS="-O2 -Wno-macro-redefined -isysroot $SDKROOT -arch arm64 -miphoneos-version-min=10.0" | ||
|
|
||
| make TARGET=ARMV8 DYNAMIC_ARCH=1 NUM_THREADS=32 HOSTCC=clang NOFORTRAN=1 | ||
| make libs TARGET=ARMV8 DYNAMIC_ARCH=1 NUM_THREADS=32 HOSTCC=clang NOFORTRAN=1 |
Collaborator
There was a problem hiding this comment.
I do not think this change is correct - why would you want to make "libs" only instead of a full build ?
Contributor
Author
There was a problem hiding this comment.
Build only the libraries (make libs) to avoid running iOS test binaries on macOS
Contributor
Author
There was a problem hiding this comment.
If you think make libs is wrong, I can roll it back. Are there any other problems?
Collaborator
There was a problem hiding this comment.
Cross-build condition should already prevent running the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original script had an invalid CFLAGS assignment (CFLAGS= -O2 ...), which caused zsh to treat -O2 as a command and fail with:
It also hardcoded the iPhoneOS SDK and Xcode toolchain paths, which may not exist on all machines and can prevent the build from running successfully.
This update:
Fix the shell syntax by assigning CFLAGS correctly
Use
xcrun --sdk iphoneos --show-sdk-pathto resolve the active iOS SDK dynamicallyBuild only the libraries (make libs) to avoid running iOS test binaries on macOS
I have tested this on a real macOS machine and the build completes successfully.