fix input_ids validation

Author: eelcovdw

packages/syft/src/syft/service/job/job_stash.py

@@ -862,9 +862,6 @@ def set_result(
         if valid.is_err():
             return SyftError(message=valid.err())
 
-        # stdlib
-        import sys
-
         # Ensure we never save cached result data in the database,
         # as they can be arbitrarily large
         if (
@@ -873,11 +870,6 @@ def set_result(
         ):
             item.result._clear_cache()
 
-        print(
-            f"(CACHE CLEARED) SETTING RESULT {item.result} for job {item.id}",
-            file=sys.stderr,
-        )
-
         return super().update(credentials, item, add_permissions)
 
     def get_by_result_id(

packages/syft/src/syft/service/output/output_service.py

@@ -116,7 +116,7 @@ def from_ids(
         else:
             job_link = None
 
-        if input_ids:
+        if input_ids is not None:
             input_ids = {k: v for k, v in input_ids.items() if isinstance(v, UID)}
         return cls(
             output_ids=output_ids,

packages/syft/src/syft/service/request/request.py

@@ -792,6 +792,8 @@ def _create_output_history_for_deposited_result(
         if input_policy is not None:
             for input_ in input_policy.inputs.values():
                 input_ids.update(input_)
+
+        input_ids = {k: v for k, v in input_ids.items() if isinstance(v, UID)}
         res = api.services.code.store_execution_output(
             user_code_id=code.id,
             outputs=result,
@@ -1088,6 +1090,7 @@ def _deposit_result_l2(
                 for inps in code.input_policy.inputs.values():
                     input_ids.update(inps)
 
+            input_ids = {k: v for k, v in input_ids.items() if isinstance(v, UID)}
             res = api.services.code.store_execution_output(
                 user_code_id=code.id,
                 outputs=result,
@@ -1104,7 +1107,13 @@ def _deposit_result_l2(
             else JobStatus.COMPLETED
         )
 
-        existing_result = job.result.id if job.result is not None else None
+        existing_result = None
+        if isinstance(job.result, ActionObject):
+            existing_result = job.result.id
+        elif isinstance(job.result, Err):
+            existing_result = job.result
+        else:
+            existing_result = job.result
         print(
             f"Job({job.id}) Setting new result {existing_result} -> {job_info.result.id}"
         )