Merge pull request #9165 from OpenMined/eelco/sync-delete-warning

add sync warning for deletions

Author: eelcovdw

packages/syft/src/syft/client/datasite_client.py

@@ -202,7 +202,12 @@ def get_sync_state(self) -> SyncState | SyftError:
 
     def apply_state(self, resolved_state: ResolvedSyncState) -> SyftSuccess | SyftError:
         if len(resolved_state.delete_objs):
-            raise NotImplementedError("TODO implement delete")
+            prompt_warning_message(
+                message=(
+                    "Attempted to delete objects by syncing. "
+                    "This is not currently supported, objects must be deleted manually."
+                )
+            )
         items = resolved_state.create_objs + resolved_state.update_objs
 
         action_objects = [x for x in items if isinstance(x, ActionObject)]

packages/syft/src/syft/service/sync/diff_state.py

@@ -39,6 +39,7 @@
 from ...util.notebook_ui.components.sync import Label
 from ...util.notebook_ui.components.sync import SyncTableObject
 from ...util.notebook_ui.icons import Icon
+from ...util.util import prompt_warning_message
 from ..action.action_object import ActionObject
 from ..action.action_permissions import ActionObjectPermission
 from ..action.action_permissions import ActionPermission
@@ -1192,6 +1193,7 @@ def from_sync_state(
         _include_server_status: bool = False,
     ) -> "ServerDiff":
         obj_uid_to_diff = {}
+        show_deletion_warning = False
         for obj_id in set(low_state.objects.keys()) | set(high_state.objects.keys()):
             low_obj = low_state.objects.get(obj_id, None)
             high_obj = high_state.objects.get(obj_id, None)
@@ -1216,6 +1218,7 @@ def from_sync_state(
             # So, skip if the object is not present on the *source* side
             source_obj = low_obj if direction == SyncDirection.LOW_TO_HIGH else high_obj
             if source_obj is None:
+                show_deletion_warning = True
                 continue
 
             diff = ObjectDiff.from_objects(
@@ -1272,6 +1275,15 @@ def from_sync_state(
             inplace=True,
         )
 
+        if show_deletion_warning:
+            prompt_warning_message(
+                message=(
+                    "The target server has objects not found on the source server. "
+                    "These objects cannot be deleted via syncing and only manual deletion is possible."
+                ),
+                confirm=False,
+            )
+
         return res
 
     @staticmethod