??? [ModelicaSystem] exception handling

Author: syntron

OMPython/ModelicaSystem.py

@@ -172,7 +172,7 @@ def __init__(
             mod = ModelicaSystem("ModelicaModel.mo", "modelName", [("Modelica","3.2.3"), "PowerSystems"])
         """
         if fileName is None and modelName is None and not lmodel:  # all None
-            raise Exception("Cannot create ModelicaSystem object without any arguments")
+            raise ModelicaSystemError("Cannot create ModelicaSystem object without any arguments")
 
         self.quantitiesList = []
         self.paramlist = {}
@@ -219,7 +219,7 @@ def __init__(
         self._raiseerrors = raiseerrors
 
         if self.fileName is not None and not self.fileName.is_file():  # if file does not exist
-            raise IOError(f"File Error: {self.fileName} does not exist!!!")
+            raise IOError(f"{self.fileName} does not exist!")
 
         # set default command Line Options for linearization as
         # linearize() will use the simulation executable and runtime
@@ -327,8 +327,8 @@ def _run_cmd(self, cmd: list, timeout: Optional[int] = None):
                 logger.info("OM output for command %s:\n%s", cmd, stdout)
         except subprocess.TimeoutExpired:
             raise ModelicaSystemError(f"Timeout running command {repr(cmd)}")
-        except Exception as e:
-            raise ModelicaSystemError(f"Exception {type(e)} running command {cmd}: {e}")
+        except Exception as ex:
+            raise ModelicaSystemError(f"Error running command {cmd}") from ex
 
     def _raise_error(self, errstr: str):
         # TODO: raise errors / cleanup / remove this function!
@@ -451,8 +451,8 @@ def getContinuous(self, names=None):  # 4
                     try:
                         value = self.getSolutions(i)
                         self.continuouslist[i] = value[0][-1]
-                    except Exception:
-                        raise ModelicaSystemError(f"OM error: {i} could not be computed")
+                    except OMCSessionException as ex:
+                        raise ModelicaSystemError(f"{i} could not be computed") from ex
                 return self.continuouslist
 
             elif isinstance(names, str):
@@ -461,7 +461,7 @@ def getContinuous(self, names=None):  # 4
                     self.continuouslist[names] = value[0][-1]
                     return [self.continuouslist.get(names)]
                 else:
-                    raise ModelicaSystemError(f"OM error: {names} is not continuous")
+                    raise ModelicaSystemError(f"{names} is not continuous")
 
             elif isinstance(names, list):
                 valuelist = []
@@ -471,7 +471,7 @@ def getContinuous(self, names=None):  # 4
                         self.continuouslist[i] = value[0][-1]
                         valuelist.append(value[0][-1])
                     else:
-                        raise ModelicaSystemError(f"OM error: {i} is not continuous")
+                        raise ModelicaSystemError(f"{i} is not continuous")
                 return valuelist
 
         raise ModelicaSystemError(f"Unhandled input for getContinous()")
@@ -731,7 +731,7 @@ def simulate(self, resultfile=None, simflags=None, timeout: Optional[int] = None
 
         exe_file = self.get_exe_file()
         if not exe_file.exists():
-            raise Exception(f"Error: Application file path not found: {exe_file}")
+            raise ModelicaSystemError(f"Application file path not found: {exe_file}")
 
         cmd = exe_file.as_posix() + override + csvinput + resultfileflag + simflags
         cmd = [s for s in cmd.split(' ') if s]
@@ -1113,7 +1113,7 @@ def linearize(self, lintime: Optional[float] = None, simflags: Optional[str] = N
             simflags = " " + simflags
 
         if not exe_file.exists():
-            raise Exception(f"Error: Application file path not found: {exe_file}")
+            raise ModelicaSystemError(f"Application file path not found: {exe_file}")
         else:
             cmd = exe_file.as_posix() + linruntime + override + csvinput + simflags
             cmd = [s for s in cmd.split(' ') if s]
@@ -1142,8 +1142,8 @@ def linearize(self, lintime: Optional[float] = None, simflags: Optional[str] = N
             self.linearstates = stateVars
             return LinearizationResult(n, m, p, A, B, C, D, x0, u0, stateVars,
                                        inputVars, outputVars)
-        except ModuleNotFoundError:
-            raise Exception("ModuleNotFoundError: No module named 'linearized_model'")
+        except ModuleNotFoundError as ex:
+            raise ModelicaSystemError("No module named 'linearized_model'") from ex
 
     def getLinearInputs(self):
         """