Integrate Clang ThreadSanitizer in tests

Author: 3manifold

.github/workflows/ci.yml

@@ -72,7 +72,7 @@ jobs:
         run: |
           tests/ctranslate2_test tests/data
           
-  build-and-test-cpp-x86_64-sanitizer:
+  build-and-test-cpp-x86_64-address_sanitizer:
     runs-on: ubuntu-22.04
     env:
       CT2_VERBOSE: 1
@@ -94,7 +94,7 @@ jobs:
           CT2_USE_MKL: 1
           MKL_VERSION: 2023.0.0
         run: |
-          sudo apt-get install -y intel-oneapi-mkl-devel-$MKL_VERSION
+          sudo apt install -y intel-oneapi-mkl-devel-$MKL_VERSION
           cmake -DCMAKE_INSTALL_PREFIX=$PWD/install -DBUILD_TESTS=ON -DENABLE_ADDRESS_SANITIZER=ON -DCMAKE_BUILD_TYPE=Debug .
 
       - name: Build
@@ -113,7 +113,49 @@ jobs:
           CT2_USE_MKL: 1
         run: |
           ASAN_OPTIONS=detect_leaks=1:print_stats=1 tests/ctranslate2_test tests/data
-          
+
+  build-and-test-cpp-x86_64-thread_sanitizer:
+    runs-on: ubuntu-22.04
+    env:
+      CT2_VERBOSE: 1
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+
+      - name: Install Intel oneAPI
+        run: |
+          wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB
+          sudo apt-key add *.PUB
+          sudo sh -c 'echo "deb https://apt.repos.intel.com/oneapi all main" > /etc/apt/sources.list.d/oneAPI.list'
+          sudo apt-get update
+
+      - name: Configure with MKL
+        env:
+          CT2_USE_MKL: 1
+          MKL_VERSION: 2023.0.0
+        run: |
+          sudo apt install -y intel-oneapi-mkl-devel-$MKL_VERSION
+          cmake -DCMAKE_INSTALL_PREFIX=$PWD/install -DBUILD_TESTS=ON -DENABLE_THREAD_SANITIZER=ON -DCMAKE_BUILD_TYPE=Debug .
+
+      - name: Build
+        run: |
+          make install
+
+      - name: Download test data
+        working-directory: tests/data/models
+        run: |
+          wget https://opennmt-models.s3.amazonaws.com/pi_lm_step_5000.pt
+          wget https://opennmt-models.s3.amazonaws.com/transliteration-aren-all.tar.gz
+          tar xf transliteration-aren-all.tar.gz
+
+      - name: Test ThreadSanitizer
+        env:
+          CT2_USE_MKL: 1
+        run: |
+          tests/ctranslate2_test tests/data
+
   build-and-test-cpp-arm64:
     runs-on: ${{ matrix.os }}
     env:

CMakeLists.txt

@@ -23,6 +23,7 @@ option(BUILD_SHARED_LIBS "Build shared libraries" ON)
 option(WITH_TENSOR_PARALLEL "Compile with NCCL and MPI backend" OFF)
 option(WITH_FLASH_ATTN "Compile with Flash Attention 2" OFF)
 option(ENABLE_ADDRESS_SANITIZER "ASAN" OFF)
+option(ENABLE_THREAD_SANITIZER "TSAN" OFF)
 
 MESSAGE(STATUS "Compiler Id: ${CMAKE_CXX_COMPILER_ID}")
 MESSAGE(STATUS "Compiler Version: ${CMAKE_CXX_COMPILER_VERSION}")
@@ -480,13 +481,20 @@ if (WITH_RUY)
   list(APPEND LIBRARIES ruy)
 endif()
 
+# sanitizers
 IF (ENABLE_ADDRESS_SANITIZER AND (CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "DEBUG"))
-  MESSAGE (STATUS "ENABLE_ADDRESS_SANITIZER: ENABLED")
+  MESSAGE (STATUS "ENABLE_ADDRESS_SANITIZER: TRUE")
   set(ASAN_FLAGS " -fsanitize=address -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-common")
   string(APPEND CMAKE_C_FLAGS ${ASAN_FLAGS})
   string(APPEND CMAKE_CXX_FLAGS ${ASAN_FLAGS})
   add_link_options(-fsanitize=address)
-ELSEIF (ENABLE_ADDRESS_SANITIZER)
+ELSEIF (ENABLE_THREAD_SANITIZER AND (CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "DEBUG"))
+  MESSAGE (STATUS "ENABLE_THREAD_SANITIZER: TRUE")
+  set(TSAN_FLAGS " -fsanitize=thread")
+  string(APPEND CMAKE_C_FLAGS ${TSAN_FLAGS})
+  string(APPEND CMAKE_CXX_FLAGS ${TSAN_FLAGS})
+  add_link_options(-fsanitize=thread)
+ELSEIF (ENABLE_ADDRESS_SANITIZER OR ENABLE_THREAD_SANITIZER)
   MESSAGE(FATAL_ERROR "SANITIZER requires Debug build type")
 ENDIF ()