Skip to content

Commit 634c561

Browse files
committed
fix(server): Return a default Name if Description exists but has not defined Name
Name is required here.
1 parent 942aa63 commit 634c561

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

packages/openneuro-server/src/datalad/__tests__/description.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,10 @@ describe("datalad dataset descriptions", () => {
101101
const repaired = repairDescriptionTypes(description)
102102
expect(repaired.DatasetType).toEqual("raw")
103103
})
104-
it("sets BIDSVersion to '1.8.0' if missing", () => {
104+
it("sets BIDSVersion to '1.11.0' if missing", () => {
105105
const description = {}
106106
const repaired = repairDescriptionTypes(description)
107-
expect(repaired.BIDSVersion).toEqual("1.8.0")
107+
expect(repaired.BIDSVersion).toEqual("1.11.0")
108108
})
109109
})
110110
describe("getDescriptionObject()", () => {

packages/openneuro-server/src/datalad/description.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,16 @@ export const repairDescriptionTypes = (description) => {
9696
}
9797
// If it's already a string, no change needed.
9898
}
99-
// If the field doesn't exist, we don't add it.
99+
// If the field doesn't exist, we don't add it (except Name)
100100
}
101101

102102
// Ensure BIDSVersion is present if missing (common default)
103-
if (!Object.hasOwn(newDescription, "BIDSVersion")) {
104-
newDescription.BIDSVersion = "1.8.0" // Or your desired default BIDS version
103+
if (!newDescription.BIDSVersion) {
104+
newDescription.BIDSVersion = "1.11.0"
105+
}
106+
// Ensure Name is present if missing
107+
if (!newDescription.Name) {
108+
newDescription.Name = "Unnamed Dataset"
105109
}
106110

107111
return newDescription

0 commit comments

Comments
 (0)