Merge pull request #3863 from OpenNeuroOrg/snapshot-update-fix

chore(worker): Remove redundant enableremote call with broken argument

Author: nellh

services/datalad/datalad_service/handlers/snapshots.py

@@ -13,7 +13,6 @@
 )
 from datalad_service.tasks.publish import (
     export_dataset,
-    monitor_remote_configs,
 )
 
 
@@ -62,7 +61,6 @@ async def on_post(self, req, resp, dataset, snapshot):
             resp.status = falcon.HTTP_OK
 
             if not skip_publishing:
-                monitor_remote_configs(ds_path)
                 # Publish after response
                 await export_dataset.kiq(ds_path)
         except SnapshotExistsException as err:

services/datalad/datalad_service/tasks/publish.py

@@ -101,7 +101,7 @@ async def export_backup_and_drop(dataset_path):
     dataset_id = os.path.basename(dataset_path)
     public_dataset = is_public_dataset(dataset_id)
     repo = pygit2.Repository(dataset_path)
-    update_s3_sibling(dataset_path)
+    update_s3_sibling(dataset_path, public_dataset)
     tags = sorted(git_tag(repo), key=lambda tag: tag.name)
     if tags:
         await s3_backup_push(dataset_path)
@@ -283,13 +283,6 @@ async def delete_siblings(dataset_id):
     await delete_github_sibling(dataset_id)
 
 
-def monitor_remote_configs(dataset_path):
-    """Check remote configs and correct invalidities."""
-    s3_ok = datalad_service.common.s3.validate_s3_config(dataset_path)
-    if not s3_ok:
-        update_s3_sibling(dataset_path)
-
-
 @broker.task
 async def annex_drop(dataset_path, branches):
     """Drop local contents from the annex."""