New version of form-processing script for updated schema#191
Open
Dvermetten wants to merge 7 commits into
Open
New version of form-processing script for updated schema#191Dvermetten wants to merge 7 commits into
Dvermetten wants to merge 7 commits into
Conversation
Contributor
Author
|
Now adresses #186 |
kvdblom
requested changes
Jul 14, 2026
kvdblom
left a comment
Collaborator
There was a problem hiding this comment.
Github action generate_html fails:
- when running
uv run yaml_to_html.py, becauseproblems.yamlcontains'?'where input should be'yes', 'no', 'some' or 'unknown'. - Happens at least for:
suite_morepoandsuite_cec2015_dmoo - Maybe these are ouput of the form processing script? Otherwise we can just change them to
unknownand that should fix it
Github action `check_new_problems fails:
- it cannot find module
pydantic_yaml - Maybe the problem is that:
pydantic_yamlis inrequirements.txtbut not inutils/requirements.txt - When running with
uv run utils/validate_yaml.py problems.yaml(rather thanpython utils/validate_yaml.py problems.yamlas in the action), the action fails withImportError: cannot import name 'default_columns' from 'yaml_to_html'
Execution of formresponse_to_yaml.py fails:
- When run with
uv run formresponse_to_yaml.py, the errorNo such file or directory: 'responses_OPL.csv'comes up - Suggestion: Change the default file name to the correct one
- Suggestion 2: Add instructions in a README (maybe in
utils? Perhaps this entire script should go there?) on how thi should be executed. - When run with
uv run formresponse_to_yaml.py --csv OPL_form.csvexecution fails with 44 validation errors -- Seemingly about execution times not being in the format expected by pydantic (but maybe not limited to that)
Collaborator
|
Merging main back in did no resolve any of these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New (generated) script for converting the form responses (csv file) to the updated schema.