Skip to content

Title localized#217

Merged
tenkus47 merged 2 commits into
devfrom
title-localized
Jun 8, 2026
Merged

Title localized#217
tenkus47 merged 2 commits into
devfrom
title-localized

Conversation

@tenkus47

@tenkus47 tenkus47 commented Jun 8, 2026

Copy link
Copy Markdown
Member

No description provided.

harshal-2304 and others added 2 commits June 3, 2026 12:42
Author groups — CMS UI, invites, notifications, and permissions
- integrated Tolgee for improved language handling in dashboard components
- updated displayDashboardItemTitle to accept localeLanguage for localized titles
- modified mapDashboardItemToTableRow to utilize localeLanguage
- added tests to verify title selection based on current UI locale
- streamlined metadata title selection logic for better fallback handling
@tenkus47 tenkus47 merged commit 2e367a5 into dev Jun 8, 2026
4 of 6 checks passed
@tenkus47 tenkus47 deleted the title-localized branch June 8, 2026 06:18
@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown

Confidence Score: 3/5

The locale-to-language mapping and fallback logic are correct and well-tested, but switching UI language will issue a redundant network request and momentarily blank the dashboard table every time.

The core title-localization logic in dashboardTable.ts and dashboardApi.ts is clean and covered by tests. The problem is in how localeLanguage is wired into the query in Dashboard.tsx: it enters the query key but is never sent to the server, so any language toggle causes an unnecessary full round-trip and a visible loading state on a page that already has correct data in cache.

Dashboard.tsx — specifically how localeLanguage participates in the React Query key and fetch cycle.

Reviews (1): Last reviewed commit: "feat(dashboard): enhance localization su..." | Re-trigger Greptile

Comment on lines 134 to 136
};

return {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Trailing whitespace was introduced on this blank line.

Suggested change
};
return {
};
return {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants