md_preview_for_detail+subtask#228
Conversation
Confidence Score: 5/5Safe to merge; the only notable behaviour gap is a minor UX glitch when the disabled prop toggles after mount, which does not lose data. All changes are additive UI improvements. The stale-tab issue when disabled transitions after mount is a cosmetic inconvenience — the user sees a disabled textarea instead of the rendered preview, but data is not lost and they can still click Preview manually. No data-path regressions were found. src/components/ui/atoms/markdown-editor.tsx — the activeTab/disabled sync gap noted above. Reviews (2): Last reviewed commit: "feat(markdown-editor): set default tab t..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| type MarkdownEditorProps = { | ||
| value: string; | ||
| onChange: (value: string) => void; | ||
| placeholder?: string; | ||
| disabled?: boolean; | ||
| className?: string; | ||
| textareaClassName?: string; | ||
| }; |
There was a problem hiding this comment.
onBlur and ref not exposed
MarkdownEditor doesn't accept or forward onBlur or ref, so every usage inside a react-hook-form FormField (see CreatePlan.tsx, LanguageDetailsCard.tsx, SubTaskCard.tsx) silently drops field.onBlur and field.ref. With the default onSubmit validation mode this doesn't break validation, but the field's touched state never updates and RHF's automatic focus-on-error (setFocus) won't work for these description fields.
3 participants
No description provided.