Skip to content

Commit 1507e67

Browse files
authored
Merge pull request #455 from OpenPecha/chore/CoverNavbar
chore: bottom up sheet now covers up the navigation bar everywhere on the app.
2 parents 777e90b + 242e52a commit 1507e67

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

lib/features/auth/presentation/widgets/login_drawer.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,15 @@ class LoginDrawer extends ConsumerStatefulWidget {
1111
const LoginDrawer({super.key});
1212

1313
/// Show the login drawer as a bottom sheet
14-
static Future<void> show(BuildContext context, WidgetRef ref) {
14+
static Future<void> show(
15+
BuildContext context,
16+
WidgetRef ref, {
17+
bool useRootNavigator = false,
18+
}) {
1519
return showModalBottomSheet(
1620
context: context,
1721
isScrollControlled: true,
22+
useRootNavigator: useRootNavigator,
1823
backgroundColor: Colors.transparent,
1924
isDismissible: true,
2025
enableDrag: true,
@@ -98,11 +103,7 @@ class _LoginDrawerState extends ConsumerState<LoginDrawer>
98103
),
99104
),
100105
// App logo
101-
Image.asset(
102-
AppAssets.weBuddhistLogo,
103-
height: 80,
104-
width: 80,
105-
),
106+
Image.asset(AppAssets.weBuddhistLogo, height: 80, width: 80),
106107
const SizedBox(height: 24),
107108
// Title
108109
Text(

lib/features/more/presentation/more_screen.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,9 @@ class MoreScreen extends ConsumerWidget {
133133
context,
134134
icon: AppAssets.signIn,
135135
title: localizations.sign_in,
136-
onTap: () => LoginDrawer.show(context, ref),
136+
onTap:
137+
() =>
138+
LoginDrawer.show(context, ref, useRootNavigator: true),
137139
),
138140
] else ...[
139141
_buildSettingsRow(
@@ -306,6 +308,7 @@ class MoreScreen extends ConsumerWidget {
306308
borderRadius: BorderRadius.vertical(top: Radius.circular(20)),
307309
),
308310
isScrollControlled: true,
311+
useRootNavigator: true,
309312
builder: (sheetContext) {
310313
final theme = Theme.of(sheetContext);
311314
final selected = currentLocale ?? Localizations.localeOf(sheetContext);

0 commit comments

Comments
 (0)