Merge pull request #466 from OpenPecha/fix-onboarding

Temporarily disable onboarding enforcement in route guard; redirect t…

Author: tentamdin

lib/core/config/router/route_guard.dart

@@ -59,23 +59,33 @@ class RouteGuard {
     String? Function() getPendingRoute,
     void Function(String?) setPendingRoute,
   ) async {
-    final hasOnboarded = await onboardingRepo.isOnboardingCompleted().then(
-      (result) =>
-          result.fold((failure) => false, (hasCompleted) => hasCompleted),
-    );
-
-    // Force onboarding if not completed
-    if (!hasOnboarded &&
-        path != AppRoutes.onboarding &&
-        path != AppRoutes.login) {
-      return AppRoutes.onboarding;
-    }
-
-    // Skip onboarding if already done
-    if (hasOnboarded && path == AppRoutes.onboarding) {
+    // Onboarding is temporarily disabled for everyone. Never force it, and
+    // send any direct navigation to /onboarding back to home. This also fixes
+    // the offline case, where the original check below defaulted to "not
+    // onboarded" and wrongly forced onboarding.
+    if (path == AppRoutes.onboarding) {
       return AppRoutes.home;
     }
 
+    // Original force-onboarding logic, preserved (commented out) so it can be
+    // re-enabled later by deleting the redirect above and uncommenting this.
+    // final hasOnboarded = await onboardingRepo.isOnboardingCompleted().then(
+    //   (result) =>
+    //       result.fold((failure) => false, (hasCompleted) => hasCompleted),
+    // );
+    //
+    // // Force onboarding if not completed
+    // if (!hasOnboarded &&
+    //     path != AppRoutes.onboarding &&
+    //     path != AppRoutes.login) {
+    //   return AppRoutes.onboarding;
+    // }
+    //
+    // // Skip onboarding if already done
+    // if (hasOnboarded && path == AppRoutes.onboarding) {
+    //   return AppRoutes.home;
+    // }
+
     // Redirect from login or splash to pending route or home
     if (path == AppRoutes.login || path == AppRoutes.splash) {
       final pending = getPendingRoute();