Merge pull request #507 from OpenPecha/fix-day-task-complete-share-button

ta4tsering · web-flow · commit b739ef7c5c5b · 2026-07-06T05:06:56.000+05:30
feat: implement sharing functionality for plan day images
diff --git a/lib/features/plans/presentation/utils/plan_day_share.dart b/lib/features/plans/presentation/utils/plan_day_share.dart
@@ -0,0 +1,99 @@
+import 'dart:io';
+
+import 'package:flutter/material.dart';
+import 'package:flutter_pecha/core/deep_linking/deep_link_url_builder.dart';
+import 'package:flutter_pecha/core/extensions/context_ext.dart';
+import 'package:flutter_pecha/shared/utils/helper_functions.dart';
+import 'package:http/http.dart' as http;
+import 'package:path_provider/path_provider.dart';
+import 'package:share_plus/share_plus.dart';
+
+/// Downloads the plan day's shareable image and shares it together with the
+/// day completion message and the plan day deep link.
+Future<void> sharePlanDayImage({
+  required BuildContext context,
+  required String shareableImageUrl,
+  required int dayNumber,
+  required String planId,
+  required String planLanguage,
+  GlobalKey? shareButtonKey,
+}) async {
+  final url = shareableImageUrl.trim();
+  if (url.isEmpty) return;
+
+  File? tempFile;
+  try {
+    final uri = Uri.parse(url);
+    final response = await http.get(uri).timeout(const Duration(seconds: 15));
+    if (response.statusCode < 200 || response.statusCode >= 300) {
+      throw HttpException(
+        'Failed to download share image (${response.statusCode})',
+        uri: uri,
+      );
+    }
+
+    final directory = await getTemporaryDirectory();
+    final extension = _imageExtensionFromUrl(uri);
+    tempFile = File(
+      '${directory.path}/plan_day_${dayNumber}_${DateTime.now().millisecondsSinceEpoch}.$extension',
+    );
+    await tempFile.writeAsBytes(response.bodyBytes);
+
+    if (!context.mounted) return;
+
+    final sharePositionOrigin = getSharePositionOrigin(
+      context: context,
+      globalKey: shareButtonKey,
+    );
+
+    final shareMessage = context.l10n.day_completion_share_message;
+    final planLink =
+        DeepLinkUrlBuilder.planDayLink(
+          planId: planId,
+          dayNumber: dayNumber,
+          language: planLanguage,
+        ).toString();
+
+    await SharePlus.instance.share(
+      ShareParams(
+        files: [XFile(tempFile.path)],
+        text: '$shareMessage\n\n$planLink',
+        sharePositionOrigin: sharePositionOrigin,
+      ),
+    );
+  } catch (_) {
+    if (context.mounted) {
+      ScaffoldMessenger.of(context).showSnackBar(
+        SnackBar(
+          content: Text(context.l10n.create_image_share_error),
+          behavior: SnackBarBehavior.floating,
+        ),
+      );
+    }
+  } finally {
+    if (tempFile != null && await tempFile.exists()) {
+      try {
+        await tempFile.delete();
+      } catch (_) {
+        // Best-effort temp cleanup.
+      }
+    }
+  }
+}
+
+String _imageExtensionFromUrl(Uri uri) {
+  final lastSegment = uri.pathSegments.isNotEmpty ? uri.pathSegments.last : '';
+  final extension =
+      lastSegment.contains('.')
+          ? lastSegment.split('.').last.toLowerCase()
+          : '';
+  switch (extension) {
+    case 'jpg':
+    case 'jpeg':
+    case 'png':
+    case 'webp':
+      return extension;
+    default:
+      return 'png';
+  }
+}
diff --git a/lib/features/plans/presentation/widgets/day_completion_bottom_sheet.dart b/lib/features/plans/presentation/widgets/day_completion_bottom_sheet.dart
@@ -1,14 +1,8 @@
-import 'dart:io';
-
 import 'package:flutter/material.dart';
 import 'package:flutter_pecha/core/constants/app_assets.dart';
-import 'package:flutter_pecha/core/deep_linking/deep_link_url_builder.dart';
 import 'package:flutter_pecha/core/extensions/context_ext.dart';
 import 'package:flutter_pecha/core/widgets/cached_network_image_widget.dart';
-import 'package:flutter_pecha/shared/utils/helper_functions.dart';
-import 'package:http/http.dart' as http;
-import 'package:path_provider/path_provider.dart';
-import 'package:share_plus/share_plus.dart';
+import 'package:flutter_pecha/features/plans/presentation/utils/plan_day_share.dart';
 
 class DayCompletionBottomSheet extends StatefulWidget {
   final int dayNumber;
@@ -211,87 +205,22 @@ class _DayCompletionBottomSheetState extends State<DayCompletionBottomSheet> {
 
     setState(() => _isSharing = true);
 
-    File? tempFile;
     try {
-      final uri = Uri.parse(url);
-      final response = await http.get(uri);
-      if (response.statusCode < 200 || response.statusCode >= 300) {
-        throw HttpException(
-          'Failed to download share image (${response.statusCode})',
-          uri: uri,
-        );
-      }
-
-      final directory = await getTemporaryDirectory();
-      final extension = _imageExtensionFromUrl(uri);
-      tempFile = File(
-        '${directory.path}/plan_day_${widget.dayNumber}_${DateTime.now().millisecondsSinceEpoch}.$extension',
-      );
-      await tempFile.writeAsBytes(response.bodyBytes);
-
-      if (!mounted) return;
-
-      final sharePositionOrigin = getSharePositionOrigin(
+      await sharePlanDayImage(
         context: context,
-        globalKey: _shareButtonKey,
-      );
-
-      final shareMessage = context.l10n.day_completion_share_message;
-      final planLink = DeepLinkUrlBuilder.planDayLink(
-        planId: widget.planId,
+        shareableImageUrl: url,
         dayNumber: widget.dayNumber,
-        language: widget.planLanguage,
-      ).toString();
-
-      await SharePlus.instance.share(
-        ShareParams(
-          files: [XFile(tempFile.path)],
-          text: '$shareMessage\n\n$planLink',
-          sharePositionOrigin: sharePositionOrigin,
-        ),
+        planId: widget.planId,
+        planLanguage: widget.planLanguage,
+        shareButtonKey: _shareButtonKey,
       );
-    } catch (_) {
-      if (mounted) {
-        ScaffoldMessenger.of(context).showSnackBar(
-          SnackBar(
-            content: Text(context.l10n.create_image_share_error),
-            behavior: SnackBarBehavior.floating,
-          ),
-        );
-      }
     } finally {
-      if (tempFile != null && await tempFile.exists()) {
-        try {
-          await tempFile.delete();
-        } catch (_) {
-          // Best-effort temp cleanup.
-        }
-      }
-
       if (mounted) {
         setState(() => _isSharing = false);
       }
     }
   }
 
-  String _imageExtensionFromUrl(Uri uri) {
-    final lastSegment =
-        uri.pathSegments.isNotEmpty ? uri.pathSegments.last : '';
-    final extension =
-        lastSegment.contains('.')
-            ? lastSegment.split('.').last.toLowerCase()
-            : '';
-    switch (extension) {
-      case 'jpg':
-      case 'jpeg':
-      case 'png':
-      case 'webp':
-        return extension;
-      default:
-        return 'png';
-    }
-  }
-
   Widget _buildProgressBar(BuildContext context, double progress) {
     final barWidth = MediaQuery.of(context).size.width - 80;
 
diff --git a/lib/features/plans/presentation/widgets/plan_track/plan_details.dart b/lib/features/plans/presentation/widgets/plan_track/plan_details.dart
@@ -6,6 +6,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter_pecha/core/analytics/analytics_events.dart';
 import 'package:flutter_pecha/core/analytics/analytics_providers.dart';
 import 'package:flutter_pecha/core/config/locale/locale_notifier.dart';
+import 'package:flutter_pecha/core/config/router/app_routes.dart';
 import 'package:flutter_pecha/core/error/failures.dart';
 import 'package:flutter_pecha/core/constants/app_assets.dart';
 import 'package:flutter_pecha/core/l10n/generated/app_localizations.dart';
@@ -23,6 +24,7 @@ import 'package:flutter_pecha/features/plans/data/models/user/user_plans_model.d
 import 'package:flutter_pecha/features/plans/data/utils/series_plan_utils.dart';
 import 'package:flutter_pecha/features/plans/data/models/user/user_tasks_dto.dart';
 import 'package:flutter_pecha/features/plans/domain/subtask_navigation.dart';
+import 'package:flutter_pecha/features/plans/presentation/utils/plan_day_share.dart';
 import 'package:flutter_pecha/features/plans/presentation/widgets/plan_navigation/plan_navigator.dart';
 import 'package:flutter_pecha/core/extensions/context_ext.dart';
 import 'package:flutter_pecha/features/plans/data/models/response/user_plan_day_detail_response.dart';
@@ -60,6 +62,8 @@ class _PlanDetailsState extends ConsumerState<PlanDetails> {
   final Set<String> _togglingTaskIds = {};
   final Map<int, bool> _dayCompletionTracker = {};
   final Map<String, bool> _optimisticCompletions = {};
+  final GlobalKey _shareButtonKey = GlobalKey();
+  bool _isSharing = false;
 
   @override
   void initState() {
@@ -215,7 +219,14 @@ class _PlanDetailsState extends ConsumerState<PlanDetails> {
     return AppBar(
       leading: IconButton(
         icon: const Icon(AppAssets.arrowLeft),
-        onPressed: () => context.pop(),
+        onPressed: () {
+          if (context.canPop()) {
+            context.pop();
+          } else {
+            // Opened via deep link with no route beneath — go home.
+            context.go(AppRoutes.home);
+          }
+        },
       ),
       title: Text(widget.plan.title, style: TextStyle(fontSize: 20)),
       elevation: 0,
@@ -711,38 +722,101 @@ class _PlanDetailsState extends ConsumerState<PlanDetails> {
         tasks.isNotEmpty &&
         tasks.any(PlanSubtaskNavigation.isUserTaskNavigable);
 
+    final shareableImageUrl = dayData?.shareableImageUrl?.trim();
+    final showShareButton =
+        dayData != null &&
+        dayData.isCompleted &&
+        shareableImageUrl != null &&
+        shareableImageUrl.isNotEmpty;
+
+    final buttonStyle = FilledButton.styleFrom(
+      backgroundColor: Theme.of(context).colorScheme.onSurface,
+      foregroundColor: Theme.of(context).colorScheme.surface,
+      disabledBackgroundColor: Theme.of(
+        context,
+      ).colorScheme.onSurface.withValues(alpha: 0.5),
+      disabledForegroundColor: Theme.of(
+        context,
+      ).colorScheme.surface.withValues(alpha: 0.85),
+      padding: const EdgeInsets.symmetric(vertical: 16),
+      shape: RoundedRectangleBorder(borderRadius: BorderRadius.circular(20)),
+    );
+
     return SafeArea(
       child: Padding(
         padding: const EdgeInsets.all(16.0),
         child: SizedBox(
           width: double.infinity,
-          child: FilledButton(
-            onPressed:
-                hasReadableContent
-                    ? () => _startReading(tasks, audioUrl: audioUrl)
-                    : null,
-            style: FilledButton.styleFrom(
-              backgroundColor: Theme.of(context).colorScheme.onSurface,
-              foregroundColor: Theme.of(context).colorScheme.surface,
-              disabledBackgroundColor: Theme.of(
-                context,
-              ).colorScheme.onSurface.withValues(alpha: 0.5),
-              padding: const EdgeInsets.symmetric(vertical: 16),
-              shape: RoundedRectangleBorder(
-                borderRadius: BorderRadius.circular(20),
-              ),
-            ),
-            child: Text(
-              localizations.start_reading,
-              style: const TextStyle(
-                fontSize: 16,
-                fontWeight: FontWeight.bold,
-                letterSpacing: -0.3,
-              ),
-            ),
-          ),
+          child:
+              showShareButton
+                  ? FilledButton.icon(
+                    key: _shareButtonKey,
+                    onPressed:
+                        _isSharing
+                            ? null
+                            : () =>
+                                _shareDay(shareableImageUrl, dayData.dayNumber),
+                    style: buttonStyle,
+                    icon:
+                        _isSharing
+                            ? SizedBox(
+                              width: 18,
+                              height: 18,
+                              child: CircularProgressIndicator(
+                                strokeWidth: 2,
+                                color: Theme.of(
+                                  context,
+                                ).colorScheme.surface.withValues(alpha: 0.85),
+                              ),
+                            )
+                            : const Icon(AppAssets.readerShare, size: 22),
+                    label: Text(
+                      localizations.share,
+                      style: const TextStyle(
+                        fontSize: 16,
+                        fontWeight: FontWeight.bold,
+                        letterSpacing: -0.3,
+                      ),
+                    ),
+                  )
+                  : FilledButton(
+                    onPressed:
+                        hasReadableContent
+                            ? () => _startReading(tasks, audioUrl: audioUrl)
+                            : null,
+                    style: buttonStyle,
+                    child: Text(
+                      localizations.start_reading,
+                      style: const TextStyle(
+                        fontSize: 16,
+                        fontWeight: FontWeight.bold,
+                        letterSpacing: -0.3,
+                      ),
+                    ),
+                  ),
         ),
       ),
     );
   }
+
+  Future<void> _shareDay(String shareableImageUrl, int dayNumber) async {
+    if (_isSharing) return;
+
+    setState(() => _isSharing = true);
+
+    try {
+      await sharePlanDayImage(
+        context: context,
+        shareableImageUrl: shareableImageUrl,
+        dayNumber: dayNumber,
+        planId: widget.plan.id,
+        planLanguage: widget.plan.language,
+        shareButtonKey: _shareButtonKey,
+      );
+    } finally {
+      if (mounted) {
+        setState(() => _isSharing = false);
+      }
+    }
+  }
 }
diff --git a/test/features/plans/plan_details_share_button_test.dart b/test/features/plans/plan_details_share_button_test.dart
