Skip to content

Chore/subplans link share#503

Merged
tentamdin merged 5 commits into
developfrom
chore/SubplansLinkShare
Jul 5, 2026
Merged

Chore/subplans link share#503
tentamdin merged 5 commits into
developfrom
chore/SubplansLinkShare

Conversation

@dhakar66

@dhakar66 dhakar66 commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

dhakar66 added 3 commits July 5, 2026 20:16
- Introduced new deep link handling for specific plans and days, allowing users to navigate directly to a plan's details or a specific day within the plan.
- Updated the `AppLinksDeepLinkService` to support plan navigation.
- Added new methods in `DeepLinkUrlBuilder` for generating plan and plan day links.
- Modified relevant UI components to utilize the new deep linking features, improving user experience when sharing and accessing plans.
- Introduced a new localized message for sharing day completion on WeBuddhist across various languages including English, Hindi, Mongolian, Nepali, Chinese, and Spanish.
- Updated localization files to include the new share message, enhancing user engagement and social sharing capabilities.
- Updated deep linking functionality to include content language for plans, allowing users to access the correct enrollment across different locales.
- Modified the `AppLinksDeepLinkService` and related components to handle language parameters in deep links.
- Enhanced UI elements to support the new language feature, improving user experience when sharing and accessing plans.
- Added initial day parameter to plan previews, ensuring users land on the correct day when navigating through deep links.
@dhakar66 dhakar66 requested a review from tentamdin July 5, 2026 16:00
@greptile-apps

greptile-apps Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge after fixing the navigation sequencing in main.dart; all other changes are straightforward additions.

The planNavigator closure in main.dart calls router.go(AppRoutes.home) and router.push(AppRoutes.practiceMyPractices) back-to-back in the same synchronous frame. Every other place in this codebase that does a go followed by a push wraps the push in addPostFrameCallback, because go_router schedules the go asynchronously and the subsequent push can be dropped or mis-applied against the pre-go stack. This means plan deep links could silently fail to open My Practices, leaving users on the home screen with no visible effect.

lib/main.dart — the planNavigator registration, specifically the router.go + router.push call sequence.

Reviews (3): Last reviewed commit: "Merge branch 'develop' into chore/Subpla..." | Re-trigger Greptile

Comment thread lib/core/deep_linking/deep_link_router.dart Outdated
tentamdin and others added 2 commits July 5, 2026 23:51
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@tentamdin tentamdin merged commit 2ffeba0 into develop Jul 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants