Skip to content

Enhance platform normalization in push configuration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenkus47 merged 2 commits into from
Jul 5, 2026
+13 −1
Merged

Enhance platform normalization in push configuration #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60f9a1f
Enhance platform normalization in push configuration
tenkus47 Jul 3, 2026
c9aca44
Add notification dispatch secret token to configuration
tenkus47 Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions worker_api/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
NOTIFICATION_DEFAULT_TITLE="WebBuddhist",
NOTIFICATION_DEFAULT_BODY="Time for your daily practice.",

NOTIFICATION_DISPATCH_SECRET_TOKEN="Dispatch",
# Optional Redis idempotency during dispatch
NOTIFICATION_IDEMPOTENCY_ENABLED="false",
NOTIFICATION_IDEMPOTENCY_TTL_SECONDS=3600,
Expand Down
13 changes: 12 additions & 1 deletion worker_api/notifications/services/push/config_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,18 @@ def is_fcm_configured() -> bool:
return bool(get("GOOGLE_CLOUD_PROJECT").strip())


def _normalize_platform(platform: str) -> str:
value = platform
if hasattr(platform, "value"):
value = platform.value
value = str(value)
if "." in value:
value = value.rsplit(".", 1)[-1]
return value.lower()


def is_push_configured(platform: str) -> bool:
if platform in ("android", "ios"):
normalized = _normalize_platform(platform)
if normalized in ("android", "ios"):
return is_fcm_configured()
return False
Loading