fix: replace hardcoded API key with secure random token#640
Open
Lidang-Jiang wants to merge 1 commit intoOpenPipe:mainfrom
Open
fix: replace hardcoded API key with secure random token#640Lidang-Jiang wants to merge 1 commit intoOpenPipe:mainfrom
Lidang-Jiang wants to merge 1 commit intoOpenPipe:mainfrom
Conversation
The vLLM server was initialized with api_key="default", allowing unauthenticated access with a well-known credential (CWE-798). Replace with _generate_api_key() that uses secrets.token_urlsafe(32), with ART_API_KEY env var override for operators who need a pinned key. Also remove "default" fallbacks in client code. Fixes OpenPipe#628 Signed-off-by: Lidang-Jiang <lidangjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The vLLM server was initialized with
api_key="default"(CWE-798), allowing unauthenticated access with a well-known credential. Any user with network access could bypass authentication usingAuthorization: Bearer default.Fix: Replace hardcoded
"default"with_generate_api_key()that:secrets.token_urlsafe(32)for a cryptographically random tokenART_API_KEYenv var for operators who need a pinned credentialopenai_server.py,local/backend.py,tinker_native/backend.py,tinker/server.pyFixes #628
Before
After
Test plan
"default"string no longer appears in anyapi_key=assignment