Skip to content

Setting up logger so tests can pass when run after JavaLoggerTest#136

Open
OrDTesters wants to merge 1 commit intoOpenPojo:masterfrom
OrDTesters:set-logger
Open

Setting up logger so tests can pass when run after JavaLoggerTest#136
OrDTesters wants to merge 1 commit intoOpenPojo:masterfrom
OrDTesters:set-logger

Conversation

@OrDTesters
Copy link
Copy Markdown
Contributor

Similar to #135, there are other tests that fail when run after other tests in JavaLoggerTest. The reason for the failure is the same, and so this pull request proposes to introduce the same logic to explicitly set the logger to Log4JLogger before the tests that need it to be set up.

One thing to note is that these tests fail when run after tests in JavaLoggerTest, so another potential way to fix is to (re)set the logger in a teardown method for JavaLoggerTest. In this style, it would be good if LoggerFactory provides a method to see what the active logger is so the test can set the active logger to that one.

Please let me know if you want to discuss the changes more.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 302

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.913%

Totals Coverage Status
Change from base Build 301: 0.0%
Covered Lines: 3145
Relevant Lines: 3279

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants