Range check job-password-supported.

michaelrsweet · michaelrsweet · commit 3d748da980e9 · 2026-04-05T10:44:10.000-04:00
diff --git a/cups/ppd-cache.c b/cups/ppd-cache.c
@@ -1,7 +1,7 @@
 /*
  * PPD cache implementation for CUPS.
  *
- * Copyright © 2022-2025 by OpenPrinting.
+ * Copyright © 2022-2026 by OpenPrinting.
  * Copyright © 2010-2021 by Apple Inc.
  *
  * Licensed under Apache License v2.0.  See the file "LICENSE" for more
@@ -3501,7 +3501,7 @@ _ppdCreateFromIPP(char   *buffer,	/* I - Filename buffer */
   * Password/PIN printing...
   */
 
-  if ((attr = ippFindAttribute(supported, "job-password-supported", IPP_TAG_INTEGER)) != NULL)
+  if ((attr = ippFindAttribute(supported, "job-password-supported", IPP_TAG_INTEGER)) != NULL && ippGetInteger(attr, 0) > 0)
   {
     char	pattern[33];		/* Password pattern */
     int		maxlen = ippGetInteger(attr, 0);

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/*`
`2`	`2`	`* PPD cache implementation for CUPS.`
`3`	`3`	`*`
`4`		`- * Copyright © 2022-2025 by OpenPrinting.`
	`4`	`+ * Copyright © 2022-2026 by OpenPrinting.`
`5`	`5`	`* Copyright © 2010-2021 by Apple Inc.`
`6`	`6`	`*`
`7`	`7`	`* Licensed under Apache License v2.0. See the file "LICENSE" for more`
`@@ -3501,7 +3501,7 @@ _ppdCreateFromIPP(char buffer, / I - Filename buffer */`
`3501`	`3501`	`* Password/PIN printing...`
`3502`	`3502`	`*/`
`3503`	`3503`
`3504`		`- if ((attr = ippFindAttribute(supported, "job-password-supported", IPP_TAG_INTEGER)) != NULL)`
	`3504`	`+ if ((attr = ippFindAttribute(supported, "job-password-supported", IPP_TAG_INTEGER)) != NULL && ippGetInteger(attr, 0) > 0)`
`3505`	`3505`	`{`
`3506`	`3506`	`char pattern[33]; /* Password pattern */`
`3507`	`3507`	`int maxlen = ippGetInteger(attr, 0);`