Add missing value tag test to cupsCheckDestSupported.

michaelrsweet · michaelrsweet · commit 7484e4824ac6 · 2026-04-22T15:04:07.000-04:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -172,6 +172,7 @@ v2.5b1 - YYYY-MM-DD
 - Fixed A4 support in the `ippevepcl` program (Issue #1544)
 - Fixed issues with the environment variable support of CGI programs
   (Issue #1547)
+- Fixed potential crash bug in `cupsCheckDestSupported` function.
 - Removed hash support for SHA2-512-224 and SHA2-512-256.
 - Removed `mantohtml` script for generating html pages (use
   `https://www.msweet.org/mantohtml/`)
diff --git a/cups/dest-options.c b/cups/dest-options.c
@@ -304,7 +304,7 @@ cupsCheckDestSupported(
   * Compare values...
   */
 
-  if (!strcmp(option, "media") && !strncmp(value, "custom_", 7))
+  if (!strcmp(option, "media") && (ippGetValueTag(attr) == IPP_TAG_KEYWORD || ippGetValueTag(attr) == IPP_TAG_NAME || ippGetValueTag(attr) == IPP_TAG_NAMELANG) && !strncmp(value, "custom_", 7))
   {
    /*
     * Check range of custom media sizes...

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ cupsCheckDestSupported(`
`304`	`304`	`* Compare values...`
`305`	`305`	`*/`
`306`	`306`
`307`		`- if (!strcmp(option, "media") && !strncmp(value, "custom_", 7))`
	`307`	`+ if (!strcmp(option, "media") && (ippGetValueTag(attr) == IPP_TAG_KEYWORD \|\| ippGetValueTag(attr) == IPP_TAG_NAME \|\| ippGetValueTag(attr) == IPP_TAG_NAMELANG) && !strncmp(value, "custom_", 7))`
`308`	`308`	`{`
`309`	`309`	`/*`
`310`	`310`	`* Check range of custom media sizes...`