Fix apparent cupsd freeze with zombie clients (Issue #1264)

michaelrsweet · michaelrsweet · commit 776d6ed22fc4 · 2025-05-14T07:30:13.000-04:00
diff --git a/CHANGES.md b/CHANGES.md
@@ -14,6 +14,7 @@ Changes in CUPS v2.4.13 (YYYY-MM-DD)
 - Fixed subscription issues in the scheduler and D-Bus notifier (Issue #1235)
 - Fixed support for IPP/PPD options with periods or underscores (Issue #1249)
 - Fixed parsing of real numbers in PPD compiler source files (Issue #1263)
+- Fixed scheduler freezing with zombie clients (Issue #1264)
 
 
 Changes in CUPS v2.4.12 (2025-04-08)
diff --git a/scheduler/client.c b/scheduler/client.c
@@ -463,7 +463,7 @@ cupsdCloseClient(cupsd_client_t *con)	/* I - Client to close */
       partial = 1;
 #endif /* HAVE_TLS */
 
-    if (partial)
+    if (partial && !httpError(con->http))
     {
      /*
       * Only do a partial close so that the encrypted client gets everything.

Original file line number	Diff line number	Diff line change
`@@ -463,7 +463,7 @@ cupsdCloseClient(cupsd_client_t con) / I - Client to close */`
`463`	`463`	`partial = 1;`
`464`	`464`	`#endif /* HAVE_TLS */`
`465`	`465`
`466`		`- if (partial)`
	`466`	`+ if (partial && !httpError(con->http))`
`467`	`467`	`{`
`468`	`468`	`/*`
`469`	`469`	`* Only do a partial close so that the encrypted client gets everything.`