Fix unreachable code in IPP backend

zdohnal · zdohnal · commit 8d80ddbab50c · 2025-09-02T10:24:47.000+02:00
diff --git a/backend/ipp.c b/backend/ipp.c
@@ -2140,14 +2140,7 @@ main(int  argc,				/* I - Number of command-line args */
 	password_tries = 0;
       else
       {
-	if (ipp_status != IPP_STATUS_ERROR_SERVICE_UNAVAILABLE &&
-	    ipp_status != IPP_STATUS_ERROR_BUSY)
-	{
-	  ippDelete(response);
-          ipp_status = IPP_STATUS_OK;
-          break;
-	}
-	else if (ipp_status == IPP_STATUS_ERROR_INTERNAL)
+	if (ipp_status == IPP_STATUS_ERROR_INTERNAL)
 	{
 	  waitjob_tries ++;
 
@@ -2158,6 +2151,13 @@ main(int  argc,				/* I - Number of command-line args */
 	    break;
 	  }
 	}
+	else if (ipp_status != IPP_STATUS_ERROR_SERVICE_UNAVAILABLE &&
+	    ipp_status != IPP_STATUS_ERROR_BUSY)
+	{
+	  ippDelete(response);
+	  ipp_status = IPP_STATUS_OK;
+	  break;
+	}
       }
 
       if (response)

Original file line number	Diff line number	Diff line change
`@@ -2140,14 +2140,7 @@ main(int argc, /* I - Number of command-line args */`
`2140`	`2140`	`password_tries = 0;`
`2141`	`2141`	`else`
`2142`	`2142`	`{`
`2143`		`- if (ipp_status != IPP_STATUS_ERROR_SERVICE_UNAVAILABLE &&`
`2144`		`- ipp_status != IPP_STATUS_ERROR_BUSY)`
`2145`		`- {`
`2146`		`- ippDelete(response);`
`2147`		`- ipp_status = IPP_STATUS_OK;`
`2148`		`- break;`
`2149`		`- }`
`2150`		`- else if (ipp_status == IPP_STATUS_ERROR_INTERNAL)`
	`2143`	`+ if (ipp_status == IPP_STATUS_ERROR_INTERNAL)`
`2151`	`2144`	`{`
`2152`	`2145`	`waitjob_tries ++;`
`2153`	`2146`
`@@ -2158,6 +2151,13 @@ main(int argc, /* I - Number of command-line args */`
`2158`	`2151`	`break;`
`2159`	`2152`	`}`
`2160`	`2153`	`}`
	`2154`	`+ else if (ipp_status != IPP_STATUS_ERROR_SERVICE_UNAVAILABLE &&`
	`2155`	`+ ipp_status != IPP_STATUS_ERROR_BUSY)`
	`2156`	`+ {`
	`2157`	`+ ippDelete(response);`
	`2158`	`+ ipp_status = IPP_STATUS_OK;`
	`2159`	`+ break;`
	`2160`	`+ }`
`2161`	`2161`	`}`
`2162`	`2162`
`2163`	`2163`	`if (response)`