Fix response from Create-Xxx-Subscriptions request to include all Subscription object attributes (Issue #1204)

michaelrsweet · michaelrsweet · commit f695cb55e07f · 2025-03-26T15:59:20.000-04:00
diff --git a/scheduler/ipp.c b/scheduler/ipp.c
@@ -1,7 +1,7 @@
 /*
  * IPP routines for the CUPS scheduler.
  *
- * Copyright © 2020-2024 by OpenPrinting
+ * Copyright © 2020-2025 by OpenPrinting
  * Copyright © 2007-2021 by Apple Inc.
  * Copyright © 1997-2007 by Easy Software Products, all rights reserved.
  *
@@ -6101,8 +6101,7 @@ create_subscriptions(
     }
 
     ippAddSeparator(con->response);
-    ippAddInteger(con->response, IPP_TAG_SUBSCRIPTION, IPP_TAG_INTEGER,
-                  "notify-subscription-id", sub->id);
+    copy_subscription_attrs(con, sub, /*ra*/NULL, /*exclude*/NULL);
 
     con->response->request.status.status_code = IPP_STATUS_OK;
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/*`
`2`	`2`	`* IPP routines for the CUPS scheduler.`
`3`	`3`	`*`
`4`		`- * Copyright © 2020-2024 by OpenPrinting`
	`4`	`+ * Copyright © 2020-2025 by OpenPrinting`
`5`	`5`	`* Copyright © 2007-2021 by Apple Inc.`
`6`	`6`	`* Copyright © 1997-2007 by Easy Software Products, all rights reserved.`
`7`	`7`	`*`
`@@ -6101,8 +6101,7 @@ create_subscriptions(`
`6101`	`6101`	`}`
`6102`	`6102`
`6103`	`6103`	`ippAddSeparator(con->response);`
`6104`		`- ippAddInteger(con->response, IPP_TAG_SUBSCRIPTION, IPP_TAG_INTEGER,`
`6105`		`- "notify-subscription-id", sub->id);`
	`6104`	`+ copy_subscription_attrs(con, sub, /ra/NULL, /exclude/NULL);`
`6106`	`6105`
`6107`	`6106`	`con->response->request.status.status_code = IPP_STATUS_OK;`
`6108`	`6107`