Pre-allocate form variables before resizing#1269
Closed
LumioseSil wants to merge 1 commit intoOpenPrinting:masterfrom
Closed
Pre-allocate form variables before resizing#1269LumioseSil wants to merge 1 commit intoOpenPrinting:masterfrom
LumioseSil wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
If the calloc fails, this is catastrophic. We cannot trust form_vars as the memory block could have changed entirely. Who knows what issues this can cause. This is undefined behavior.
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
If the realloc fails the original memory block is unchanged. And the existing code doesn't allocate one element at a time, either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the calloc fails, this is catastrophic. We cannot trust form_vars as the memory block could have changed entirely. Who knows what issues this can cause. This is undefined behavior.