Skip to content

Pre-allocate form variables before resizing #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LumioseSil wants to merge 1 commit into from
Closed

Pre-allocate form variables before resizing #1269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions cgi-bin/var.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,45 +616,41 @@ cgi_add_variable(const char *name, /* I - Variable name */
const char *value) /* I - Variable value */
{
_cgi_var_t *var; /* New variable */


char **pre_alloc;

if (name == NULL || value == NULL || element < 0 || element > 100000)
return;

pre_alloc = calloc((size_t)element + 1, sizeof(char *));

if (pre_alloc == NULL)
return;

if (form_count >= form_alloc)
{
_cgi_var_t *temp_vars; /* Temporary form pointer */



if (form_alloc == 0)
temp_vars = malloc(sizeof(_cgi_var_t) * 16);
else
temp_vars = realloc(form_vars, (size_t)(form_alloc + 16) * sizeof(_cgi_var_t));

if (!temp_vars)
return;

var = temp_vars + form_count;

if ((var->values = calloc((size_t)element + 1, sizeof(char *))) == NULL)
{
/*
* Rollback changes
*/

if (form_alloc == 0)
free(temp_vars);
free(pre_alloc);
return;
}

form_vars = temp_vars;
form_alloc += 16;

var = temp_vars + form_count;
}
else
{
var = form_vars + form_count;
if ((var->values = calloc((size_t)element + 1, sizeof(char *))) == NULL)
return;
}

var->values = pre_alloc;

var->name = strdup(name);
var->nvalues = element + 1;
Expand Down
Loading