Introduce print-as-raster as printer/job attribute#1282
Introduce print-as-raster as printer/job attribute#1282zdohnal merged 1 commit intoOpenPrinting:masterfrom
Conversation
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
I like the idea of this but would prefer to use a different attribute/option name, e.g., "print-as-raster", to keep the naming consistent with other print mode options/attributes.
Also, the job-state-reasons keyword needs to stay as "cups-retry-as-raster" since we save this information (when a job had to be retried) for accounting/diagnostic purposes.
zdohnal
changed the title
zdohnal
force-pushed
the
force-raster
branch
2 times, most recently
from
1583a91 to
bec5409
Compare
|
@michaelrsweet thank you for the review! I have applied the feedback + taken the liberty to update man pages to include the option. Feel free to check once you have the moment. |
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
One minor change and we are good. I think I also want to update the cupsdCreateCommonData function in scheduler/printers.c to include a "print-as-raster-supported" boolean attribute with value true.
Some printers do not take kindly newer PDF versions which results in omitting font characters in the printout. Such jobs print fine as a raster, however retrying as raster depends on benevolence of the printer firmware what it counts as an unrecoverable printing error. In the past, we preferred raster over PDF in cups-filters, causing other issues like with finishings, or solutions like generating PCLm PPD were mentioned, however it would require a way how to define for which models it should be used, and take of such database. Thus introducing `print-as-raster` job attribute, which makes the job to be printed as raster, and `print-as-raster-default` printer attributes, which makes any job coming into the printer object to be printed as raster. Internally it uses similar mechanism as raster retry, which was adjusted to match both use cases now.
|
Added, thank you! |
2 participants
EDITED - see the old version in history.
Some printers do not take kindly newer PDF versions which results in
omitting font characters in the printout. Such jobs print fine as a
raster, however retrying as raster depends on benevolence of the printer
firmware what it counts as an unrecoverable printing error.
In the past, we preferred raster over PDF in cups-filters, causing other
issues like with finishings, or solutions like generating PCLm PPD were
mentioned, however it would require a way how to define for which models
it should be used, and take of such database.
Thus introducing
print-as-rasterjob attribute, which makes the jobto be printed as raster, and
print-as-raster-defaultprinter attributes,which makes any job coming into the printer object to be printed as raster.
Internally it uses similar mechanism as raster retry, which was adjusted
to match both use cases now.