Add Chinese (zh_CN/zh_TW) web UI, static doc home pages, and packaging#1535
Open
jackadam1981 wants to merge 1 commit intoOpenPrinting:masterfrom
Open
Add Chinese (zh_CN/zh_TW) web UI, static doc home pages, and packaging#1535jackadam1981 wants to merge 1 commit intoOpenPrinting:masterfrom
jackadam1981 wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
- Add templates/zh_CN and templates/zh_TW for localized CUPS web interface - Add doc/zh_CN and doc/zh_TW static index.html (shared $DOCDIR/cups.css) - desktop/cups.desktop.in: zh_CN and zh_TW Name/Comment entries - packaging/cups.list.in and cups.spec.in: install templates and localized doc trees;
michaelrsweet
requested changes
Apr 20, 2026
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
This PR is missing files for the new "home.tmpl" template, which replaced the index.html file last year... If you can address those missing files and address my other comments then I'll be happy to merge these changes in the master branch for CUPS 2.5.
Thanks!
| @@ -0,0 +1,52 @@ | |||
| <!DOCTYPE HTML> | |||
Member
There was a problem hiding this comment.
This file is no longer used in the master branch.
| @@ -0,0 +1,52 @@ | |||
| <!DOCTYPE HTML> | |||
Member
There was a problem hiding this comment.
This file is also no longer used in the master branch.
|
|
||
| #d 0755 root sys $DOCDIR/zh_TW | ||
| #f 0444 root sys $DOCDIR/zh_TW doc/zh_TW/*.html | ||
| # zh_CN/zh_TW: static doc/index.html (like other locales); CSS is $DOCDIR/cups.css. |
Member
There was a problem hiding this comment.
These are no longer used (and I need to update the list file to reflect that...)
| /usr/share/doc/cups/pt_BR/* | ||
| %dir /usr/share/doc/cups/ru | ||
| /usr/share/doc/cups/ru/* | ||
| # zh_CN/zh_TW: localized static doc index. |
Member
There was a problem hiding this comment.
Likewise, there are no more language-specific files in this directory for CUPS 2.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Simplified Chinese (
zh_CN) and Traditional Chinese (zh_TW) for the CUPS web interface: localized templates, static localized doc home pages, desktop entries, and packaging install rules.Scope
templates/zh_CN/andtemplates/zh_TW/(localized UI strings).doc/zh_CN/anddoc/zh_TW/staticindex.html(shared site CSS under$DOCDIR).desktop/cups.desktop.in—Name/Commentforzh_CNandzh_TW.packaging/cups.list.inandpackaging/cups.spec.in— install the above paths; locale.polisting incups.list.instays aligned with upstream (no extrazh_CNline;zh_TW.poremains commented like upstream).Upstream alignment
doc/index.html.in/templates/header.tmpl.ininconfigure;doc/MakefileWEBPAGESmatches upstream (no rootdoc/index.htmlinstall).templates/header.tmpl,templates/printer-added.tmpl,locale/cups_zh_CN.po; removedlocale/cups_zh_TW.po.Makefiledistcleanincludes upstream wildcard cleanup fordoc/*/index.htmlandtemplates/*/header.tmpl(restore tracked locale files withgit checkoutafterdistcleanif needed).Testing
zh_CNorzh_TWand exercise the web UI; confirm doc home pages and templates load.