scheduler: Raise auth failure log level from DEBUG to WARN for fail2ban compatibility#1561
Open
abubakarsabir924-cell wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
Author
|
Hi @michaelrsweet Sir, I have submitted PR #[PR 1561] for this issue. I changed the log level from CUPSD_LOG_DEBUG to CUPSD_LOG_WARN in scheduler/auth.c line 2084, where the 'User not in group(s)' message is logged before returning HTTP_STATUS_UNAUTHORIZED. This ensures authentication failures are visible when LogLevel is set to error, enabling fail2ban to work correctly with CUPS. Please review and let me know if any changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1553
When LogLevel is set to "error" in cupsd.conf, authentication
failure messages were logged at CUPSD_LOG_DEBUG level and never
appeared in logs. This prevented fail2ban from detecting failed
login attempts and blocked brute force protection.
This change raises the log level from CUPSD_LOG_DEBUG to
CUPSD_LOG_WARN for the "User not in group(s)" message in
scheduler/auth.c, ensuring it appears in logs regardless of
the configured LogLevel.