Fix some clang-detected issues:

- cups_open didn't always preserve the errno value.
- ipp_file_t had an unused token_cb member.
- cupsOAuthGetTokens didn't check for a NULL access_expires pointer.
- ipptransform tried to continue running program after the pipe creation failed.

Author: michaelrsweet

cups/file.c

@@ -656,7 +656,7 @@ cupsFileOpen(const char *filename,	// I - Name of file
 	break;
 
     case 'w' : // Write file
-        fd = cups_open(filename, O_WRONLY | O_LARGEFILE | O_BINARY, perm);
+        fd    = cups_open(filename, O_WRONLY | O_LARGEFILE | O_BINARY, perm);
 	if (fd < 0 && errno == ENOENT)
 	{
 	  fd = cups_open(filename, O_WRONLY | O_CREAT | O_EXCL | O_LARGEFILE | O_BINARY, perm);
@@ -1790,7 +1790,9 @@ cups_open(const char *filename,		// I - Filename
   // Then verify that the file descriptor doesn't point to a directory or hard-linked file.
   if (fstat(fd, &fileinfo))
   {
+    int temp = errno;
     close(fd);
+    errno = temp;
     return (-1);
   }
 
@@ -1816,7 +1818,9 @@ cups_open(const char *filename,		// I - Filename
   // Then use lstat to determine whether the filename is a symlink...
   if (lstat(filename, &linkinfo))
   {
+    int temp = errno;
     close(fd);
+    errno = temp;
     return (-1);
   }
 

cups/ipp-file.c

@@ -1,7 +1,7 @@
 //
 // IPP data file functions.
 //
-// Copyright © 2021-2024 by OpenPrinting.
+// Copyright © 2021-2025 by OpenPrinting.
 // Copyright © 2007-2019 by Apple Inc.
 // Copyright © 1997-2007 by Easy Software Products.
 //
@@ -33,7 +33,6 @@ struct _ipp_file_s			// IPP data file
   cups_option_t		*vars;		// Variables
   ipp_fattr_cb_t	attr_cb;	// Attribute (filter) callback
   ipp_ferror_cb_t	error_cb;	// Error reporting callback
-  ipp_ftoken_cb_t	token_cb;	// Token processing callback
   void			*cb_data;	// Callback data
   char			*buffer;	// Output buffer
   size_t		alloc_buffer;	// Size of output buffer

cups/oauth.c

@@ -1308,12 +1308,15 @@ cupsOAuthGetTokens(
 
   if (error)
   {
-    // Handle "soft" device access token errors by setting access_expires to
-    // the next call time...
-    if (!strcmp(error, "slow_down"))
-      *access_expires = time(NULL) + 10;
-    else
-      *access_expires = time(NULL) + 5;
+    if (access_expires)
+    {
+      // Handle "soft" device access token errors by setting access_expires to
+      // the next call time...
+      if (!strcmp(error, "slow_down"))
+	*access_expires = time(NULL) + 10;
+      else
+	*access_expires = time(NULL) + 5;
+    }
 
     // Free memory and return...
     cupsJSONDelete(response);

tools/ipptransform.c

@@ -2763,14 +2763,15 @@ ps_convert_pdf(
   if (pipe(stdout_pipe))
   {
     cupsLangPrintf(stderr, _("%s: Unable to create pipe for stdout: %s"), Prefix, strerror(errno));
-    stdout_pipe[0] = stdout_pipe[1] = -1;
+    return (1);
   }
 
   if ((pdftops_pid = fork()) == 0)
   {
     // Child comes here...
     close(1);
     dup2(stdout_pipe[1], 1);
+
     close(stdout_pipe[0]);
     close(stdout_pipe[1]);