Add empty common_name checks (Issue #125)

Author: michaelrsweet

CHANGES.md

@@ -17,6 +17,8 @@ libcups v3.0.0 (YYYY-MM-DD)
 - Updated the `httpSetCookie` API to support multiple "Set-Cookie:" header
   values.
 - Updated `ippfind` to use the `cupsGetClock` API.
+- Fixed input checks for `cupsCreateCredentials` and
+  `cupsCreateCredentialsRequest` APIs (Issue #125)
 - Fixed return values of `ippDateToTime` when the timezone isn't GMT.
 - Fixed a potential timing issue with `cupsEnumDests`.
 - Fixed a bug in the Avahi implementation of `cupsDNSSDBrowseNew`.

cups/tls-gnutls.c

@@ -205,7 +205,7 @@ cupsCreateCredentials(
   if (!path)
     path = http_default_path(defpath, sizeof(defpath));
 
-  if (!path || !common_name)
+  if (!path || !common_name || !*common_name)
   {
     _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(EINVAL), 0);
     goto done;
@@ -561,7 +561,7 @@ cupsCreateCredentialsRequest(
   if (!path)
     path = http_default_path(defpath, sizeof(defpath));
 
-  if (!path || !common_name)
+  if (!path || !common_name || !*common_name)
   {
     _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(EINVAL), 0);
     goto done;

cups/tls-openssl.c

@@ -290,7 +290,7 @@ cupsCreateCredentials(
   if (!path)
     path = http_default_path(defpath, sizeof(defpath));
 
-  if (!path || !common_name)
+  if (!path || !common_name || !*common_name)
   {
     _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(EINVAL), 0);
     return (false);
@@ -606,7 +606,7 @@ cupsCreateCredentialsRequest(
   if (!path)
     path = http_default_path(temp, sizeof(temp));
 
-  if (!path || !common_name)
+  if (!path || !common_name || !*common_name)
   {
     _cupsSetError(IPP_STATUS_ERROR_INTERNAL, strerror(EINVAL), 0);
     return (false);