feat(container): reintroduce isImageNamed function with expanded parsing logic and unit tests

- Moved `isImageNamed` function to public scope with improved handling of image tags and digests.
- Added `ImageNameTest` class with comprehensive unit tests to validate repository matching logic.
- Updated default image versions in configurations and documentation to reflect specific version tags.

Author: CoderYellow

core/src/main/kotlin/org/openprojectx/bigdata/test/core/BigDataTestKitOptions.kt

@@ -2,8 +2,8 @@ package org.openprojectx.bigdata.test.core
 
 import org.testcontainers.containers.GenericContainer
 
-const val DEFAULT_LOCALSTACK_S3_IMAGE = "ghcr.io/openprojectx/dockerhub/floci/floci:latest"
-const val DEFAULT_FAKE_GCS_IMAGE = "ghcr.io/openprojectx/dockerhub/floci/floci-gcp:latest"
+const val DEFAULT_LOCALSTACK_S3_IMAGE = "ghcr.io/openprojectx/dockerhub/floci/floci:1.5.32"
+const val DEFAULT_FAKE_GCS_IMAGE = "ghcr.io/openprojectx/dockerhub/floci/floci-gcp:0.5.0"
 
 data class BigDataTestKitOptions(
     val kerberos: KerberosOptions = KerberosOptions(),

core/src/main/kotlin/org/openprojectx/bigdata/test/core/container/BigDataContainerFactory.kt

@@ -798,11 +798,6 @@ internal class BigDataContainerFactory(
     private fun fakeGcsServicePort(): Int =
         if (isFlociGcp()) 4588 else 4443
 
-    private fun String.isImageNamed(repository: String): Boolean {
-        val image = substringBefore("@").substringBefore(":")
-        return image == repository || image.endsWith("/$repository")
-    }
-
     private fun hiveMetastoreObjectStoreConfiguration(): Map<String, String> =
         buildMap {
             if (options.hdfs.enabled) {
@@ -1713,3 +1708,11 @@ internal class BigDataContainerFactory(
         val HADOOP_IMAGE_ENV_TO_CONF_BROKEN_FORMATS = setOf("env", "sh", "cfg", "conf")
     }
 }
+
+internal fun String.isImageNamed(repository: String): Boolean {
+    val withoutDigest = substringBefore("@")
+    val lastSlash = withoutDigest.lastIndexOf('/')
+    val tagSeparator = withoutDigest.indexOf(':', startIndex = lastSlash + 1)
+    val image = if (tagSeparator >= 0) withoutDigest.substring(0, tagSeparator) else withoutDigest
+    return image == repository || image.endsWith("/$repository")
+}

core/src/test/kotlin/org/openprojectx/bigdata/test/core/container/ImageNameTest.kt

@@ -0,0 +1,27 @@
+package org.openprojectx.bigdata.test.core.container
+
+import org.junit.jupiter.api.Assertions.assertFalse
+import org.junit.jupiter.api.Assertions.assertTrue
+import org.junit.jupiter.api.Test
+
+class ImageNameTest {
+    @Test
+    fun `matches repository with registry port and tag`() {
+        assertTrue("registry.example:5000/floci/floci:latest".isImageNamed("floci/floci"))
+    }
+
+    @Test
+    fun `matches repository with registry port and digest`() {
+        assertTrue("registry.example:5000/floci/floci@sha256:abcdef".isImageNamed("floci/floci"))
+    }
+
+    @Test
+    fun `matches unqualified repository and tag`() {
+        assertTrue("floci/floci-gcp:latest".isImageNamed("floci/floci-gcp"))
+    }
+
+    @Test
+    fun `does not match a repository suffix in the image name`() {
+        assertFalse("registry.example:5000/custom-floci/floci:latest".isImageNamed("floci/floci"))
+    }
+}

doc/user-guide.adoc

@@ -236,8 +236,8 @@ clouderaHmsMariadb = "ghcr.io/openprojectx/cloudera-hms:0.1.74-mariadb"
 kafka = "apache/kafka:4.1.2"
 schemaRegistry = "confluentinc/cp-schema-registry:7.8.0"
 kafkaUi = "ghcr.io/kafbat/kafka-ui:latest"
-localStackS3 = "ghcr.io/openprojectx/dockerhub/floci/floci:latest"
-fakeGcs = "ghcr.io/openprojectx/dockerhub/floci/floci-gcp:latest"
+localStackS3 = "ghcr.io/openprojectx/dockerhub/floci/floci:1.5.32"
+fakeGcs = "ghcr.io/openprojectx/dockerhub/floci/floci-gcp:0.5.0"
 ----
 
 Kafka and the open-source HMS database sidecar use typed Testcontainers classes instead of plain generic containers. When you override those images, `bigdata-test` marks the configured Kafka image as a compatible substitute for `apache/kafka`, PostgreSQL as a compatible substitute for `postgres`, and MySQL as a compatible substitute for `mysql`, so private mirrors or rebuilt images can still pass Testcontainers image checks.

example/spark/src/test/resources/spark-bigdata-test-common.toml

@@ -9,8 +9,8 @@ clouderaHmsMariadb = "ghcr.io/openprojectx/cloudera-hms:0.1.74-mariadb"
 kafka = "apache/kafka:4.1.2"
 schemaRegistry = "confluentinc/cp-schema-registry:7.8.0"
 kafkaUi = "ghcr.io/kafbat/kafka-ui:latest"
-localStackS3 = "ghcr.io/openprojectx/dockerhub/floci/floci:latest"
-fakeGcs = "ghcr.io/openprojectx/dockerhub/floci/floci-gcp:latest"
+localStackS3 = "ghcr.io/openprojectx/dockerhub/floci/floci:1.5.32"
+fakeGcs = "ghcr.io/openprojectx/dockerhub/floci/floci-gcp:0.5.0"
 
 [services]
 hdfs = true