Add TrICal emulator datastore group#12
Open
glasses666 wants to merge 1 commit into
Open
Conversation
TrICal needs a typed dataschema group before its QuTiP backend can return portable HDF5 output. This adds the smallest domain group for saved times, state trajectories, and final states while keeping existing generic GroupBase behavior unchanged. Constraint: oqd-trical issue #44 requires the group to be contributed upstream to oqd-dataschema Constraint: Datastore attrs only support scalar values, so run metadata remains a caller-side concern here Confidence: high Scope-risk: narrow Directive: Keep emulator-specific fields in this group limited to serialized simulation data, not backend runtime objects Tested: uv run --extra tests pytest tests/ -q Tested: uv run ruff check src tests Tested: git diff --check
3 tasks
benjimaclellan
left a comment
benjimaclellan
left a comment
Member
There was a problem hiding this comment.
@glasses666 Thanks for the PR. This looks great, I don't have any feedback. I will manage the hackathon feedback/acceptance on the PRs on the oqd-trical repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: adds a typed datastore group for TrICal emulator outputs.
Related to OpenQuantumDesign/oqd-trical#44.
oqd-tricalneeds a typedoqd-dataschemagroup before its QuTiP backend can return HDF5-serializable datastore results instead of an ad hoc dict.Adds
TrICalEmulatorDataGroup, exported fromoqd_dataschema, with datasets for:tspan: 1D float timelinestates: complex ket or density-matrix trajectoryfinal_state: complex final ket or density matrixThe new tests cover ket and density-matrix HDF5 round trips plus validation of complex state data.
No. This only adds a new registered group type and public export.
AI-assisted with OpenAI Codex; the diff was reviewed and locally verified before submission.
Validation run locally: