Fix Dynamiqs backend for AtomicCircuit simulation (#43)#50
Open
CodeMaverick2 wants to merge 1 commit into
Open
Fix Dynamiqs backend for AtomicCircuit simulation (#43)#50CodeMaverick2 wants to merge 1 commit into
CodeMaverick2 wants to merge 1 commit into
Conversation
CodeMaverick2
force-pushed
the
fix/43-dynamiqs-backend
branch
from
ffb5be6 to
98f7bf9
Compare
Correct dq.sesolve usage (method/Tsit5), document units and Diffrax defaults, add time rescaling and solver options, and add parity tests for Rabi and red sideband. Disables progress meter by default (fixes OpenQuantumDesign#26). Fixes OpenQuantumDesign#43
CodeMaverick2
force-pushed
the
fix/43-dynamiqs-backend
branch
from
98f7bf9 to
2af0482
Compare
4 tasks
Author
|
@benjimaclellan Would love to know your thoughts on the PR |
Member
|
Thanks @CodeMaverick2, I really appreciate the work here and on the other OQD issues. After comparing with #52 I'm going to select that one as the primary fix, but I appreciate the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Dynamiqs
sesolveintegration soAtomicCircuitsimulations run end-to-end and agree with QuTiP on reference Rabi and red-sideband circuits.Changes
dq.sesolve(method=dq.method.Tsit5, not invalidsolver/dq.solver)DynamiqsSolverOptions(units, Tsit5, rtol/atol, optional time rescaling,progress_meter=Falsefor Jupyter/DynamiqsBackend failing with ZMQError #26)DynamiqsBackend.compile; tensor product in cross-subsystemOperatorMulDynamiqsBackend.run_task()+TaskArgsAtomicEmulatorfor Diffrax options (until promoted in oqd-core)Test plan
uv run pytest tests/test_backends.py -v(9 passed, 2 xfailed)Fixes #43