Skip to content

Updated ModSDK files to playtest-20241116#30

Merged
pchote merged 2 commits into
OpenRA:masterfrom
penev92:prep-2411
Dec 18, 2024
Merged

Updated ModSDK files to playtest-20241116#30
pchote merged 2 commits into
OpenRA:masterfrom
penev92:prep-2411

Conversation

@penev92
Copy link
Copy Markdown
Member

@penev92 penev92 commented Nov 24, 2024

To get in line with OpenRA/OpenRAModSDK#198.

The .editorconfig is a copy of the one used in the main OpenRA repo.
The rest is trivial.

@penev92
Copy link
Copy Markdown
Member Author

penev92 commented Nov 24, 2024

Oops I didn't check for code violations after updating the .editorconfig 🤦‍♂️

@penev92
Copy link
Copy Markdown
Member Author

penev92 commented Dec 15, 2024

Updated.

void ITick.Tick(Actor self)
{
t += 1;
t++;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could simplify further to if (++t > 2)

@pchote
Copy link
Copy Markdown
Member

pchote commented Dec 15, 2024

Can you please also change:

$env:MOD_SEARCH_PATHS = "./mods,$env:ENGINE_DIRECTORY/mods"

to:

 $env:MOD_SEARCH_PATHS = "./mods" 

This should hopefully fix the Windows CI failure.

@penev92
Copy link
Copy Markdown
Member Author

penev92 commented Dec 18, 2024

Updated.

@pchote pchote merged commit ff3255d into OpenRA:master Dec 18, 2024
@penev92 penev92 deleted the prep-2411 branch December 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants