Add zstd library#44
Merged
Merged
Conversation
This was referenced Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to add the zstd dependency for OpenRCT2/OpenRCT2#24734. That PR will require making a new release with this library added to make this work.
While we need to make a new release anyways, I went ahead and updated the libraries that were already in here as well. I opted to update it to the 2025.07.25 release tag. It looks like vcpkg has a release cadence of roughly every 2-3 months, which seems like a fairly stable stable update speed, and it might be a good idea to try to update the dependencies every vcpkg update (or every other update).
With the update, I found I had to downgrade nlohmann-json to prevent build issues. This is because the 3.12.0 release had an issue related to
std::u8stringand standard library support (nlohmann/json#4733), which caused a number of build issues. It has been fixed in the latest git version, but a release hasn't been made with that change yet. For now, I opted to just pin the previous release until a new release of the library has been made. (see OpenRCT2/OpenRCT2#24226)