Rework palette information into palettes.dat#25681
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
3845973 to
aa7992a
Compare
Has this been done already? |
f509f27 to
cf9a97d
Compare
Thanks, it has been done now. The commit introducing the |
cf9a97d to
c693ff1
Compare
545c657 to
f9dd3f7
Compare
f9dd3f7 to
ca717e3
Compare
mixiate
left a comment
There was a problem hiding this comment.
I tested this and didn't find any differences.
Tested with diffing giant screenshots from the command line of various parks (nedesigns, dkmp, etc).
Made a very quick test with glass scenery:
transparenttest.zip
Tested a few ui screenshots and things that use the marker palettes.
Palettes.dat doesn't get built with msvc, gym has a patch for it though as I can't leave it as a suggestion here.
Have only briefly looked at the code but seems okay.
ca717e3 to
0c89a49
Compare
0c89a49 to
1759c98
Compare
1759c98 to
e4eccbe
Compare
|
The rework of palette sprites has been split off to #25844. That just leaves the update to |
e4eccbe to
44f0d80
Compare
Gymnasiast
left a comment
There was a problem hiding this comment.
Seems to work. I tried compressing the PNGs with zopflipng but that just caused some very weird effects.
@mixiate Could you give it one more test?
mixiate
left a comment
There was a problem hiding this comment.
Did the same tests as before and it's all good.
Building on the font information having already been moved to
fonts.dat(#24342), this PR reworks the palette information, such that the game can be launched without G1. This would be useful for 'onboarding' purposes, e.g. selecting the game path if it cannot be automatically detected. Currently, this has been implemented using various platform-specific dialog toolkits (e.g. Zenity/KDialog).Previously, there were several places where palettes were defined, and in different orders, no less. This has now been harmonised, compiling all palette info into its own graphics file,
palettes.dat. This collects our extended (remap) palettes together with the vanilla (remap) palettes.As part of dumping all palettes, the old text palette was also dumped. However, as of #25658, this is no longer necessary. It should probably be removed from this PR as well.