front: drop last step auto 0ms stop on reverse

Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>

Author: Synar

front/src/modules/pathfinding/helpers/__tests__/reversePathSteps.spec.ts

@@ -101,7 +101,7 @@ describe('reversePathSteps', () => {
       },
       name: 'Carantilly-Marigny',
       arrival: null,
-      stopFor: new Duration({ milliseconds: 0 }),
+      stopFor: null,
       locked: false,
       receptionSignal: 'OPEN',
       theoreticalMargin: '2min/100km',
@@ -178,13 +178,14 @@ describe('reversePathSteps', () => {
     ...pathStep,
     arrival: null,
   }));
+  expectedTwiceReversedPathSteps[pathSteps.length - 1].stopFor = null; // The 0ms stop on the last step will get add back later by another function
 
   it('should reverse path steps with times and margins correctly', () => {
     const reversedPathSteps = reversePathSteps(pathSteps);
     expect(reversedPathSteps).toEqual(expectedReversedPathSteps);
   });
 
-  it('should equal itself with arrival times removed when reversed twice', () => {
+  it('should equal itself with arrival times removed and last step 0ms stop missing when reversed twice', () => {
     const twiceReversedPathSteps = reversePathSteps(reversePathSteps(pathSteps));
     expect(twiceReversedPathSteps).toEqual(expectedTwiceReversedPathSteps);
   });

front/src/modules/pathfinding/helpers/reversePathSteps.ts

@@ -22,11 +22,15 @@ function reversePathSteps(pathSteps: PathStep[]): PathStep[] {
   });
 
   return pathSteps
-    .map((pathStep, index) => ({
-      ...pathStep,
-      arrival: null, // Remove arrival times set as they may become incoherent when reversing
-      theoreticalMargin: newMargins[index],
-    }))
+    .map((pathStep, index) => {
+      const isLastStepZeroStop = index === pathSteps.length - 1 && pathStep.stopFor?.ms === 0;
+      return {
+        ...pathStep,
+        arrival: null, // Remove arrival times set as they may become incoherent when reversing
+        stopFor: isLastStepZeroStop ? null : pathStep.stopFor, // We automatically insert a 0ms stop on the last step, which should be dropped before reversing
+        theoreticalMargin: newMargins[index],
+      };
+    })
     .reverse();
 }