Merged
Conversation
This was referenced Sep 9, 2025
emersion
force-pushed
the
emr/front-flat-eslint-cfg
branch
2 times, most recently
from
e1af9d6 to
249934e
Compare
emersion
force-pushed
the
emr/front-flat-eslint-cfg
branch
from
249934e to
bc49c63
Compare
SharglutDev
approved these changes
Sep 12, 2025
Contributor
SharglutDev
left a comment
SharglutDev
left a comment
There was a problem hiding this comment.
Great job, thanks for handling this painful migration !
Just 2 minor questions
emersion
force-pushed
the
emr/front-flat-eslint-cfg
branch
from
bc49c63 to
02fc5ef
Compare
Contributor
|
Something went wrong in the rebase ? The commit name /description doesn't seem to be the good one :) |
emersion
force-pushed
the
emr/front-flat-eslint-cfg
branch
2 times, most recently
from
888d796 to
8eccd79
Compare
Member
Author
Oops, fixed now! |
emersion
force-pushed
the
emr/front-flat-eslint-cfg
branch
from
8eccd79 to
897c611
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Member
Author
|
Hmm, unfortunately |
Member
Author
This is required to get support for flat config files: rollup/plugins#1898 Signed-off-by: Simon Ser <contact@emersion.fr>
ESLint v9 requires flat configs, it no longer supports the legacy config file format. Migrate our configuration file to prepare for the bump. --ext has been removed from the package.json script because ESLint rejects that CLI option when used with flat configs: file extensions are now specified in the config file directly. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
emr/front-flat-eslint-cfg
branch
from
897c611 to
8cd1875
Compare
Member
Author
|
The rollup plugin PR linked above has been merged, so this can progress now! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint v9 requires flat configs, it no longer supports the legacy
config file format. Migrate our configuration file to prepare for
the bump.
--ext has been removed from the package.json script because ESLint
rejects that CLI option when used with flat configs: file extensions
are now specified in the config file directly.
Depends on #13105
Part of #12395
See also #13134