Conversation
Member
Author
|
Waiting a bit until rollup/plugins#1905 gets merged. |
Member
Author
|
I've tried adding a dependency version override as described in rollup/plugins#1708 but the rollup plugin still ended up grabbing ESLint v8 instead of v9 for some reason… |
Contributor
|
LGTM :) everything builds, runs, and behaves as expected thanks @emersion |
achrafmohye
approved these changes
Oct 29, 2025
clarani
approved these changes
Nov 4, 2025
The right-hand-side of the expression is never used, because a non-empty string is always truthy. Signed-off-by: Simon Ser <contact@emersion.fr>
emersion
force-pushed
the
eslint-v9
branch
3 times, most recently
from
7e1417d to
fc1122e
Compare
Unused eslint-disable comments now cause ESLint warnings. Signed-off-by: Simon Ser <contact@emersion.fr>
Signed-off-by: Simon Ser <contact@emersion.fr> Closes: #12395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Closes: #12395