Skip to content

editoast: list rolling_stocks privileges#17243

Merged
younesschrifi merged 1 commit into
feature-branch/check-rolling-stock-privilegesfrom
yci/AuthzRollingStockList
Jun 24, 2026
Merged

editoast: list rolling_stocks privileges#17243
younesschrifi merged 1 commit into
feature-branch/check-rolling-stock-privilegesfrom
yci/AuthzRollingStockList

Conversation

@younesschrifi

@younesschrifi younesschrifi commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Add a protected list_rolling_stock method to verify access privileges for a list of rolling stocks.

Caution

THIS PR targets a feature branch ( see this issue)

@github-actions github-actions Bot added the area:editoast Work on Editoast Service label Jun 16, 2026
@younesschrifi younesschrifi force-pushed the yci/AuthzRollingStockList branch from 0b79414 to 31dd655 Compare June 16, 2026 13:49
@younesschrifi younesschrifi changed the base branch from dev to feature-branch/check-rolling-stock-privileges June 17, 2026 10:07

@Sh099078 Sh099078 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread editoast/authz/src/v2/rolling_stock.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
@younesschrifi younesschrifi force-pushed the yci/AuthzRollingStockList branch 2 times, most recently from d558a5c to 5527b8f Compare June 22, 2026 09:41
@younesschrifi younesschrifi marked this pull request as ready for review June 22, 2026 09:41
@younesschrifi younesschrifi requested a review from a team as a code owner June 22, 2026 09:41
@younesschrifi younesschrifi requested a review from leovalais June 22, 2026 09:42

@Sh099078 Sh099078 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of review, a few things to doublecheck in the endpoint handler about error management, the other comments are nitpicks :)

Comment thread editoast/authz/src/v2/rolling_stock.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
@younesschrifi younesschrifi force-pushed the yci/AuthzRollingStockList branch 4 times, most recently from 69975df to 99ceb74 Compare June 23, 2026 13:30

@flomonster flomonster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@leovalais leovalais left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided ⏬, thanks!

Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs
@younesschrifi younesschrifi force-pushed the yci/AuthzRollingStockList branch 2 times, most recently from ccfe568 to 919abdb Compare June 24, 2026 08:20

@Sh099078 Sh099078 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Comment thread editoast/authz/src/v2/rolling_stock.rs
Comment thread editoast/authz/src/v2/rolling_stock.rs Outdated
Comment thread editoast/src/views/rolling_stock/light.rs
@younesschrifi younesschrifi force-pushed the yci/AuthzRollingStockList branch 2 times, most recently from 5be4bab to 95f0532 Compare June 24, 2026 09:52
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
@younesschrifi younesschrifi force-pushed the yci/AuthzRollingStockList branch from 95f0532 to 6462876 Compare June 24, 2026 10:10
@younesschrifi younesschrifi merged commit 61083bb into feature-branch/check-rolling-stock-privileges Jun 24, 2026
31 checks passed
@younesschrifi younesschrifi deleted the yci/AuthzRollingStockList branch June 24, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:editoast Work on Editoast Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants