editoast: add check privileges for delete and put rolling stock endpoint#17359
Merged
younesschrifi merged 2 commits intoJul 3, 2026
Merged
Conversation
younesschrifi
force-pushed
the
yci/putRollingStock
branch
from
8b3658c to
77cfe76
Compare
younesschrifi
force-pushed
the
yci/checkGetRollingStockId
branch
3 times, most recently
from
bf067ac to
31e9c74
Compare
Base automatically changed from
yci/checkGetRollingStockId
to
feature-branch/check-rolling-stock-privileges
June 24, 2026 08:20
15 tasks
Sh099078
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
61083bb to
016cefe
Compare
younesschrifi
force-pushed
the
yci/putRollingStock
branch
2 times, most recently
from
597f825 to
35a05e9
Compare
younesschrifi
changed the title
younesschrifi
force-pushed
the
yci/putRollingStock
branch
from
35a05e9 to
3a63de4
Compare
Sh099078
reviewed
Jun 26, 2026
Sh099078
left a comment
Sh099078
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Mostly LGTM. We skip the SystemAuthorizer sanity checks when authz is skipped, maybe that's not the behavior we want ?
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
9cda363 to
af93581
Compare
younesschrifi
force-pushed
the
yci/putRollingStock
branch
3 times, most recently
from
8c825bc to
b35e9b8
Compare
Sh099078
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
af93581 to
49c63ff
Compare
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
49c63ff to
25b1202
Compare
Sh099078
approved these changes
Jul 2, 2026
younesschrifi
force-pushed
the
yci/putRollingStock
branch
from
b35e9b8 to
15da9ff
Compare
leovalais
approved these changes
Jul 2, 2026
leovalais
left a comment
leovalais
left a comment
Contributor
There was a problem hiding this comment.
Thanks, for the exhaustive test suite as well! :)
younesschrifi
force-pushed
the
yci/putRollingStock
branch
from
15da9ff to
2934a60
Compare
younesschrifi
force-pushed
the
feature-branch/check-rolling-stock-privileges
branch
from
25b1202 to
c6e470e
Compare
younesschrifi
force-pushed
the
yci/putRollingStock
branch
2 times, most recently
from
342566f to
5d65ee4
Compare
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
Signed-off-by: Youness CHRIFI ALAOUI <youness.chrifi@gmail.com>
younesschrifi
force-pushed
the
yci/putRollingStock
branch
from
5d65ee4 to
300f9bc
Compare
younesschrifi
merged commit 61bd932
into
feature-branch/check-rolling-stock-privileges
31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds privileges checks for delete (
CanRevoke) and put (CanWrite) rolling stock endpoints.Caution
This PR targets a feature branch