editoast: merge middleware authorization extensions#17362
Merged
Conversation
Sh099078
force-pushed
the
lf/merge-authz-extensions
branch
from
ec653b0 to
18b098f
Compare
Sh099078
changed the title
leovalais
reviewed
Jun 23, 2026
leovalais
left a comment
leovalais
left a comment
Contributor
There was a problem hiding this comment.
Not sold on ignoring authentication headers and the resulting change of whoami, I just read the first commit.
Sh099078
force-pushed
the
lf/merge-authz-extensions
branch
2 times, most recently
from
285ea9a to
b565849
Compare
Sh099078
force-pushed
the
lf/merge-authz-extensions
branch
2 times, most recently
from
4144c1f to
2c5146b
Compare
Khoyo
force-pushed
the
lf/merge-authz-extensions
branch
2 times, most recently
from
c2a99fb to
53ccf0f
Compare
leovalais
approved these changes
Jun 29, 2026
leovalais
left a comment
leovalais
left a comment
Contributor
There was a problem hiding this comment.
LGTM provided Extension<editoast_models::User>
Sh099078
force-pushed
the
lf/merge-authz-extensions
branch
from
53ccf0f to
bdeb556
Compare
Contributor
Author
I added back the extension in 13f8b79 |
Sh099078
force-pushed
the
lf/merge-authz-extensions
branch
from
13f8b79 to
5cb0814
Compare
Remove several middleware extensions that were used for authorization. Replace them on call sites by the updated `State` middleware extension that should contain all the information required. Add some quality of life methods for `State` to make its usage simpler. Co-authored-by: Younes Khoudli <younes.khoudli@epita.fr> Signed-off-by: Younes Khoudli <younes.khoudli@epita.fr> Signed-off-by: Loup Federico <16464925+Sh099078@users.noreply.github.com>
Sh099078
force-pushed
the
lf/merge-authz-extensions
branch
from
5cb0814 to
cd51391
Compare
github-project-automation
Bot
moved this from Awaiting merge
to Awaiting Validation
in Board PI 20
leovalais
reviewed
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the stack of authentication middlewares that we use in Editoast.
Remove several middleware extensions that were used for authorization. Replace them on call sites by the updated
Statemiddleware extension that should contain all the information required.