Skip to content

front, editoast: turn SearchPayload.object into enum#17365

Merged
QuentinHayK merged 1 commit into
devfrom
qhk/make_search_payload_object_field_enum
Jun 25, 2026
Merged

front, editoast: turn SearchPayload.object into enum#17365
QuentinHayK merged 1 commit into
devfrom
qhk/make_search_payload_object_field_enum

Conversation

@QuentinHayK

@QuentinHayK QuentinHayK commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

See #15031

@github-actions github-actions Bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service kind:api-change labels Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

@QuentinHayK QuentinHayK linked an issue Jun 24, 2026 that may be closed by this pull request
editoast: SearchPayload.object should be an enum #15031
Closed
@QuentinHayK QuentinHayK moved this to Awaiting merge in Board PI 20 Jun 24, 2026
@QuentinHayK QuentinHayK self-assigned this Jun 24, 2026
@QuentinHayK
QuentinHayK force-pushed the qhk/make_search_payload_object_field_enum branch 2 times, most recently from 7ef16a8 to f413408 Compare June 24, 2026 12:09
@QuentinHayK
QuentinHayK marked this pull request as ready for review June 24, 2026 12:09
@QuentinHayK
QuentinHayK requested review from a team as code owners June 24, 2026 12:09
@QuentinHayK
QuentinHayK enabled auto-merge June 24, 2026 12:12
leovalais
leovalais approved these changes Jun 24, 2026
View reviewed changes

@leovalais leovalais left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better thanks!

Comment thread editoast/src/views/search.rs Outdated
@QuentinHayK
front, editoast: turn SearchPayload.object into enum
6351598 
Signed-off-by: Quentix <quentin.hay-kergrohenn@epita.fr>
@QuentinHayK
QuentinHayK force-pushed the qhk/make_search_payload_object_field_enum branch from f413408 to 6351598 Compare June 24, 2026 12:20
Math-R
Math-R approved these changes Jun 25, 2026
View reviewed changes

@Math-R Math-R left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typing, lgtm :)

@QuentinHayK
QuentinHayK added this pull request to the merge queue Jun 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 25, 2026
@QuentinHayK
QuentinHayK added this pull request to the merge queue Jun 25, 2026
Merged via the queue into dev with commit 4509204 Jun 25, 2026
32 checks passed
@QuentinHayK
QuentinHayK deleted the qhk/make_search_payload_object_field_enum branch June 25, 2026 13:06
@github-project-automation github-project-automation Bot moved this from Awaiting merge to Awaiting Validation in Board PI 20 Jun 25, 2026
@louisgreiner louisgreiner moved this from Awaiting Validation to Done in Board PI 20 Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woshilapin woshilapin woshilapin approved these changes
@leovalais leovalais leovalais approved these changes
@Math-R Math-R Math-R approved these changes
@aschantraine aschantraine aschantraine approved these changes
@emersion emersion Awaiting requested review from emersion

Assignees

@QuentinHayK QuentinHayK

Labels

area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules kind:api-change

Projects

Board PI 20
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

editoast: SearchPayload.object should be an enum

6 participants

@QuentinHayK @woshilapin @leovalais @Math-R @aschantraine @louisgreiner