Skip to content

core: expose allowed track sections in the pathfinding api#17372

Merged
MartinBourbier merged 1 commit into
devfrom
mbr/pathfinding-expose-allowed-tracks
Jun 25, 2026
Merged

core: expose allowed track sections in the pathfinding api#17372
MartinBourbier merged 1 commit into
devfrom
mbr/pathfinding-expose-allowed-tracks

Conversation

@MartinBourbier

Copy link
Copy Markdown
Contributor

Part of #16699

The pathfinding api did not use any track section constraints whereas the simulation did which means that pathfinding requests might be valid but their corresponding simulation may not have been doable.

This PR only implements the core part: editoast and front will follow soon

@MartinBourbier MartinBourbier self-assigned this Jun 24, 2026
@MartinBourbier MartinBourbier requested a review from a team as a code owner June 24, 2026 13:32
@MartinBourbier MartinBourbier requested a review from eckter June 24, 2026 13:32
@MartinBourbier MartinBourbier moved this to In Progress in Board PI 20 Jun 24, 2026
@github-actions github-actions Bot added the area:core Work on Core Service label Jun 24, 2026
@MartinBourbier MartinBourbier force-pushed the mbr/pathfinding-expose-allowed-tracks branch from 4675e90 to d5d20bf Compare June 24, 2026 13:34
Comment thread core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathfindingBlocksEndpoint.kt Outdated
Comment thread core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathfindingBlocksEndpoint.kt Outdated
@bougue-pe bougue-pe removed the request for review from eckter June 24, 2026 14:30
Comment thread core/src/test/kotlin/fr/sncf/osrd/pathfinding/PathfindingTest.kt Outdated
Comment thread core/src/main/kotlin/fr/sncf/osrd/api/pathfinding/PathfindingBlocksEndpoint.kt Outdated
@MartinBourbier MartinBourbier force-pushed the mbr/pathfinding-expose-allowed-tracks branch from d5d20bf to 772a5c6 Compare June 24, 2026 18:11
The pathfinding api did not use any track section constraints whereas
the simulation did which means that pathfinding requests might be valid but
their corresponding simulation may not have been doable.

Signed-off-by: Martin Bourbier <mbourbier28@gmail.com>
@MartinBourbier MartinBourbier force-pushed the mbr/pathfinding-expose-allowed-tracks branch from 772a5c6 to 771c3bd Compare June 24, 2026 18:15
@MartinBourbier MartinBourbier requested review from Erashin and Khoyo June 24, 2026 18:34

@Erashin Erashin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job and thanks for that! Been waiting for this feature for a while :)
As long as you modify the STDCMEndpoint's allowedTrackSections accordingly, this looks mergeable to me! (This could be done in another PR btw, as it will entail small changes on the editoast side as well)

@MartinBourbier MartinBourbier force-pushed the mbr/pathfinding-expose-allowed-tracks branch from 5ddf165 to 771c3bd Compare June 25, 2026 08:00
@MartinBourbier MartinBourbier enabled auto-merge June 25, 2026 08:44
@MartinBourbier MartinBourbier added this pull request to the merge queue Jun 25, 2026
Merged via the queue into dev with commit e515e10 Jun 25, 2026
62 checks passed
@MartinBourbier MartinBourbier deleted the mbr/pathfinding-expose-allowed-tracks branch June 25, 2026 09:07
@github-project-automation github-project-automation Bot moved this from In Progress to Awaiting Validation in Board PI 20 Jun 25, 2026
@MartinBourbier MartinBourbier moved this from Awaiting Validation to Done in Board PI 20 Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Work on Core Service

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants