front: backport fixes around train header#17375
Merged
Merged
Conversation
Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Signed-off-by: Pivouane (Pierre Santamaria) <pierrenumber1@outlook.com> Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
If there is no maximum value set to the DurationInput, it's not possible to offer a proper width to the greatest unit input; instead, let's set it with the current value length (or 1 if it's zero-length). Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
As soon as you enter the first letter of the unit, move to the next unit field; like if you are writing `2h30`, we move the focus to the minutes field automatically as soon as you write `h`. As a convenience, the same is done with `:`. Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
It's somewhat expected by user to be able to "confirm" that we ended the change in an input by pressing Enter. This is what is done here by doing what is done on a blur when that key is entered. Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
It's rare that we want line-height to be defined in an absolute manner; I think this was a typo here (that happened to match what is expected most of the time, but not in small mode). Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Using a modal dialog do not let inputs keep their focus: after all, the whole point of a modal is that there cannot be an interaction outside of that modal… which defeat the point. Using popover let us keep the best of both worlds: still using the top layer so they are not 'cut' by any overflows, while keeping the focus in the input that caused their opening. Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
It's not a modal anymore, and it never was, so let's not keep this name which could confuse other contributors in the long run. Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
In OSRD, we use fields inside of wrappers that scrolls themselves. Using popovers, we punch these divs through all those wrappers into the top-layer; this prevents the computation from actually positionning the div at the right place. This should be reverted/removed altogether with this hook as soon as we have CSS native anchoring, as it won't have this kind of problems at all. Signed-off-by: Stanislas Signoud (Signez) <signez@stanisoft.net>
SharglutDev
approved these changes
Jun 25, 2026
github-project-automation
Bot
moved this from Awaiting merge
to Awaiting Validation
in Board PI 20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport fixes from: