Fix assembly bugs in EMS integration tests#1449
Merged
Merged
Conversation
Merged
Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix remaining EMS integration tests to pass
Fix assembly bugs in EMS integration tests
Oct 29, 2025
maximilien-noal
approved these changes
Oct 29, 2025
maximilien-noal
added a commit
that referenced
this pull request
Oct 29, 2025
* Initial plan * Add EMS unit and integration test structure with initial tests Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * Fix EMS tests to call methods directly, 16 unit tests and 12 integration tests passing Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * Fix EMS unit tests - 33 out of 48 passing, all integration tests completed Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * Fix EMS unit tests - remove leftover state setup, now 40/48 passing Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * Fix missing method calls in EMS tests - now 42/48 unit, 13/17 integration passing Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * Fix GetExpandedMemoryHardwareInformation test - now 43/48 unit tests passing Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * Changes before error encountered Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * fix: EMS Restore Page Map is dependant on Save Pag Map being called first * Fix assembly bugs in EMS integration tests (#1449) * Initial plan * Fix EMS integration test assembly bugs - all 17 tests now pass Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> * chore: typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three EMS integration tests were failing due to incorrect x86 assembly encoding in the test programs. The EMS implementation itself is correct.
Fixes
Device name detection test: Missing DS segment setup and incorrect offset calculation
push cs; pop dsto set DS=CS before DOS file open callMemory access tests: Missing ES segment override prefixes on write instructions
mov byte [es:0], imminstructions (3 occurrences)Example
Before (writes to DS:0 instead of ES:0):
After (correctly writes to ES:0):
All 17 integration tests and 47 unit tests now pass.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.