Skip to content

Release/v11#1454

Merged
maximilien-noal merged 1 commit into
masterfrom
release/v11
Oct 31, 2025
Merged

Release/v11#1454
maximilien-noal merged 1 commit into
masterfrom
release/v11

Conversation

@maximilien-noal
Copy link
Copy Markdown
Member

@maximilien-noal maximilien-noal commented Oct 31, 2025

https://github.com/OpenRakis/Spice86/wiki/Spice86-v11-release-notes

New release of the nuget packages.

YAML files should not fail now, even with a rc nuget package as a dependancy (MUNT wrapper for MT-32 emulation), and even if the Spice86 package is already published.

Edits to PR.YML amount to: each PR merged into master should create a new Nuget pre-release package.

@maximilien-noal maximilien-noal self-assigned this Oct 31, 2025
@maximilien-noal maximilien-noal changed the base branch from new_pit_pic_opl_adg_passing_tests to master October 31, 2025 20:47
@maximilien-noal maximilien-noal added the release New Nuget release label Oct 31, 2025
Copilot AI review requested due to automatic review settings October 31, 2025 21:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Spice86 from version 10.0.0 to 11.0.0 across build configuration and CI workflows. The changes prepare the project for a new major release with updated versioning, improved NuGet publishing workflows, and enhanced GitHub Actions permissions.

  • Updated release notes URL from v10 to v11
  • Bumped hardcoded package version references from 10.0.0 to 11.0.0 in CI workflows
  • Added prerelease NuGet package publishing to GitHub Packages with dynamic versioning
  • Standardized NuGet push commands and added OS matrix filtering to prevent duplicate uploads

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/Directory.Build.props Updated release notes URL to point to v11 wiki page
.github/workflows/prerelease.yml Added permissions block, dynamic prerelease versioning based on commit SHA, and new NuGet package publishing steps to GitHub Packages
.github/workflows/nuget.yml Updated hardcoded version references from 10.0.0 to 11.0.0, added OS matrix filtering to NuGet upload steps, standardized push command syntax, and added NU5104 warning suppression

Comment thread src/Directory.Build.props Outdated
Comment thread .github/workflows/prerelease.yml Outdated
@maximilien-noal maximilien-noal merged commit 83b6341 into master Oct 31, 2025
5 checks passed
@maximilien-noal maximilien-noal removed the request for review from kevinferrare October 31, 2025 22:49
@maximilien-noal maximilien-noal deleted the release/v11 branch November 8, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release New Nuget release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants