Skip to content

feat: CFG Blocks baked into execution engine#2166

Merged
kevinferrare merged 1 commit into
masterfrom
feature/cfg_blocks
May 17, 2026
Merged

feat: CFG Blocks baked into execution engine#2166
kevinferrare merged 1 commit into
masterfrom
feature/cfg_blocks

Conversation

@kevinferrare
Copy link
Copy Markdown
Contributor

@kevinferrare kevinferrare commented May 10, 2026

Description of Changes

Rationale behind Changes

Suggested Testing Steps

Screenshot from 2026-05-15 19-16-27

Copilot AI review requested due to automatic review settings May 10, 2026 20:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@kevinferrare kevinferrare force-pushed the feature/cfg_blocks branch 2 times, most recently from 1a33882 to 21aff40 Compare May 12, 2026 23:18
Copy link
Copy Markdown
Contributor

@github-advanced-security github-advanced-security AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@kevinferrare kevinferrare force-pushed the feature/cfg_blocks branch 12 times, most recently from a0eed62 to 6255771 Compare May 16, 2026 21:06
Comment thread tests/Spice86.Tests/CfgCpu/Blocks/CfgBlockGraphExporterTest.cs Fixed
Comment thread tests/Spice86.Tests/CfgCpu/Blocks/CfgBlockGraphExporterTest.cs Fixed
Comment thread tests/Spice86.Tests/CfgCpu/Blocks/CfgBlockGraphExporterTest.cs Fixed
Comment thread tests/Spice86.Tests/CfgCpu/Blocks/CfgBlockGraphExporterTest.cs Fixed
Comment thread tests/Spice86.Tests/CfgCpu/CfgNodeExecutionCompilerTest.cs Dismissed
Comment thread tests/Spice86.Tests/MachineTest.cs Fixed
Comment thread tests/Spice86.Tests/MachineTest.cs Fixed
Comment thread tests/Spice86.Tests/UI/CfgCpu/CfgCpuViewModelTest.cs Fixed
Comment thread tests/Spice86.Tests/UI/CfgCpu/CfgCpuViewModelTest.cs Fixed
@maximilien-noal
Copy link
Copy Markdown
Member

No regressions found (around 30 games quickly tested). Approved!

@kevinferrare kevinferrare merged commit 8e3b06e into master May 17, 2026
5 checks passed
@maximilien-noal maximilien-noal added CFGCPU Related to the future Control Flow CPU reverse engineering Related to reverse enginneering (features, APIs, ...) labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CFGCPU Related to the future Control Flow CPU reverse engineering Related to reverse enginneering (features, APIs, ...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants