fix: failing tests in Linux CI environment#2175
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Linux CI instability by removing unnecessary Avalonia headless test initialization from expression evaluator tests and updating related package versions.
Changes:
- Replaced
AvaloniaFactwith plain xUnitFactfor non-UI expression evaluator tests. - Updated Avalonia, FluentAssertions, and ASP.NET Core OpenAPI package versions.
- Normalized indentation in the test central package props file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/Spice86.Tests/UI/ExpressionEvaluatorUITests.cs |
Uses standard xUnit facts for tests that only exercise service logic. |
tests/Directory.Packages.props |
Updates test package versions for FluentAssertions and Avalonia headless packages. |
src/Directory.Packages.props |
Updates application Avalonia packages and Microsoft.AspNetCore.OpenApi. |
kevinferrare
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Replaces AvaloniaFact with Fact on ExpressionEvaluatorService tests in the Spice86 UI tests.
Updates Nuget packages for Avalonia, FluentAssertions, and ASP .NET Core OpenAPI.
Rationale behind Changes
Makes CI on Linux useful again.